Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hanlde the throttling error in the response header #2442

Merged
merged 4 commits into from
May 17, 2024
Merged

hanlde the throttling error in the response header #2442

merged 4 commits into from
May 17, 2024

Conversation

Zhangxunmt
Copy link
Collaborator

@Zhangxunmt Zhangxunmt commented May 13, 2024 •
edited
Loading

Description

Handle the throttling error in the header when the error is only returned in the headers and response body is empty. This is for a specific case discussed in the issues below.

Issues Resolved

#2429, #2249

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 13, 2024 22:31 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 13, 2024 22:31 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 13, 2024 22:31 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 13, 2024 22:33 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 13, 2024 22:33 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 13, 2024 23:35 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 13, 2024 23:35 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 13, 2024 23:35 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 13, 2024 23:35 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 13, 2024 23:35 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env May 17, 2024 18:35 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 17, 2024 18:35 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 17, 2024 21:18 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 17, 2024 21:19 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 17, 2024 21:59 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 17, 2024 21:59 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env May 17, 2024 21:59 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt merged commit 7add721 into opensearch-project:main May 17, 2024
8 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 17, 2024
@Zhangxunmt @github-actions
hanlde the throttling error in the response header (#2442)
bc43b91 
* hanlde the throttling error in the response header

Signed-off-by: Xun Zhang <[email protected]>

* address comments and UT

Signed-off-by: Xun Zhang <[email protected]>

* more UTs

Signed-off-by: Xun Zhang <[email protected]>

* add more comments

Signed-off-by: Xun Zhang <[email protected]>

---------

Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit 7add721)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 17, 2024
Merged
Zhangxunmt added a commit that referenced this pull request May 17, 2024
@opensearch-trigger-bot @Zhangxunmt
hanlde the throttling error in the response header (#2442) (#2457)
d37f636 
* hanlde the throttling error in the response header

Signed-off-by: Xun Zhang <[email protected]>

* address comments and UT

Signed-off-by: Xun Zhang <[email protected]>

* more UTs

Signed-off-by: Xun Zhang <[email protected]>

* add more comments

Signed-off-by: Xun Zhang <[email protected]>

---------

Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit 7add721)

Co-authored-by: Xun Zhang <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 17, 2024
@Zhangxunmt @github-actions
hanlde the throttling error in the response header (#2442)
20ad769 
* hanlde the throttling error in the response header

Signed-off-by: Xun Zhang <[email protected]>

* address comments and UT

Signed-off-by: Xun Zhang <[email protected]>

* more UTs

Signed-off-by: Xun Zhang <[email protected]>

* add more comments

Signed-off-by: Xun Zhang <[email protected]>

---------

Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit 7add721)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 17, 2024
Merged
dhrubo-os pushed a commit that referenced this pull request May 17, 2024
@opensearch-trigger-bot @Zhangxunmt
hanlde the throttling error in the response header (#2442) (#2461)
b6eabda 
* hanlde the throttling error in the response header

Signed-off-by: Xun Zhang <[email protected]>

* address comments and UT

Signed-off-by: Xun Zhang <[email protected]>

* more UTs

Signed-off-by: Xun Zhang <[email protected]>

* add more comments

Signed-off-by: Xun Zhang <[email protected]>

---------

Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit 7add721)

Co-authored-by: Xun Zhang <[email protected]>
@ylwu-amzn ylwu-amzn mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am left review comments

@dhrubo-os dhrubo-os dhrubo-os left review comments

@ylwu-amzn ylwu-amzn ylwu-amzn left review comments

@zhichao-aws zhichao-aws zhichao-aws approved these changes

@b4sjoo b4sjoo b4sjoo approved these changes

@jngz-es jngz-es jngz-es approved these changes

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

Assignees
No one assigned
Labels
backport feature/multi_tenancy backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Zhangxunmt @jngz-es @ylwu-amzn @dhrubo-os @Hailong-am @b4sjoo @zhichao-aws