Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test of PredictionITTests and RestConnectorToolIT #2437

Merged

Conversation

Hailong-am
Copy link
Contributor

@Hailong-am Hailong-am commented May 10, 2024

Description

  1. Add per-defined cluster setting to disable MLSyncUpJob for JVM private OpenSearch Cluster, so that it will not create .plugin-ml-config index automatically every 10 seconds.
  2. Skip RestConnectorToolIT if AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY are not set
  3. Add retry for creating connector if ML encryption master key has not been initialized yet

Issues Resolved

#2436

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env May 10, 2024 16:01 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env May 10, 2024 16:01 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env May 10, 2024 16:01 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env May 10, 2024 16:01 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env May 10, 2024 16:01 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env May 10, 2024 16:01 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env May 10, 2024 16:58 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env May 10, 2024 16:58 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env May 10, 2024 16:58 — with GitHub Actions Inactive
@Hailong-am Hailong-am changed the title fix flaky test of prediction fix flaky test of PredictionITTests May 11, 2024
@ylwu-amzn
Copy link
Collaborator

@Hailong-am Can you rebase with main branch and check if IT can pass?

@Hailong-am Hailong-am force-pushed the flaky_test_fix_predication branch from 0cb6e58 to bcaee80 Compare June 11, 2024 00:31
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env June 11, 2024 00:31 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env June 11, 2024 00:31 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env June 11, 2024 00:31 — with GitHub Actions Inactive
@Hailong-am Hailong-am had a problem deploying to ml-commons-cicd-env June 11, 2024 00:32 — with GitHub Actions Failure
@ylwu-amzn
Copy link
Collaborator

Add per-defined cluster setting to disable MLSyncUpJob for JVM private OpenSearch Cluster, so that it will not create .plugin-ml-config index automatically every 10 seconds.

This seems a code bug. Can you confirm this is just impacting IT ?

Copy link
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to unblock falied IT for 2.15 release

@ylwu-amzn ylwu-amzn merged commit f28bb74 into opensearch-project:main Jun 12, 2024
6 of 12 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2437-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f28bb740e87cd520190b003011303d5a85d477d6
# Push it to GitHub
git push --set-upstream origin backport/backport-2437-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2437-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.15 2.15
# Navigate to the new working tree
cd .worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-2437-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f28bb740e87cd520190b003011303d5a85d477d6
# Push it to GitHub
git push --set-upstream origin backport/backport-2437-to-2.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport/backport-2437-to-2.15.

rbhavna pushed a commit to rbhavna/ml-commons that referenced this pull request Jun 12, 2024
…ch-project#2437)

* fix flaky test of prediction

Signed-off-by: Hailong Cui <[email protected]>

* add retry for creating connector

Signed-off-by: Hailong Cui <[email protected]>

* disable SyncUpJob only for PredictionITTests

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit f28bb74)
rbhavna pushed a commit to rbhavna/ml-commons that referenced this pull request Jun 12, 2024
…ch-project#2437)

* fix flaky test of prediction

Signed-off-by: Hailong Cui <[email protected]>

* add retry for creating connector

Signed-off-by: Hailong Cui <[email protected]>

* disable SyncUpJob only for PredictionITTests

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit f28bb74)
rbhavna added a commit that referenced this pull request Jun 12, 2024
…oolIT (#2437) (#2547)

* fix flaky test of PredictionITTests and RestConnectorToolIT (#2437)

Signed-off-by: Hailong Cui <[email protected]>

Signed-off-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
rbhavna added a commit that referenced this pull request Jun 13, 2024
…ToolIT (#2437) (#2548)

* fix flaky test of PredictionITTests and RestConnectorToolIT (#2437)

Signed-off-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
@mingshl mingshl added the flaky-test Flaky build or test issue label Jul 11, 2024
@b4sjoo b4sjoo added the v2.15.0 label Jul 26, 2024
dhrubo-os pushed a commit to dhrubo-os/ml-commons that referenced this pull request Oct 2, 2024
…ToolIT (opensearch-project#2437) (opensearch-project#2548)

* fix flaky test of PredictionITTests and RestConnectorToolIT (opensearch-project#2437)

Signed-off-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
dhrubo-os added a commit that referenced this pull request Oct 2, 2024
…ToolIT (#2437) (#2548) (#3039)

* fix flaky test of PredictionITTests and RestConnectorToolIT (#2437)

Signed-off-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants