-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deploySetting in registering local models #2415
Conversation
Signed-off-by: Xun Zhang <[email protected]>
From the description
The code fix seems not just for pre-trained model. Seems we are fixing for all local models, right? |
Yes it should be for all models. I just verified with registering model from url and it applies to that case too. |
Got it, you can update the description to make it accurate |
What about pre-trained models? What happens for those models? How can we add deploy settings to those models? Do we need to update the documentation as well for pre-trained models? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2415-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9478fd4db292a8657c6dd13005c5a8beb8bc7d6a
# Push it to GitHub
git push --set-upstream origin backport/backport-2415-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.14 2.14
# Navigate to the new working tree
cd .worktrees/backport-2.14
# Create a new branch
git switch --create backport/backport-2415-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9478fd4db292a8657c6dd13005c5a8beb8bc7d6a
# Push it to GitHub
git push --set-upstream origin backport/backport-2415-to-2.14
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.14 Then, create a pull request where the |
…t#2415) Signed-off-by: Xun Zhang <[email protected]>
…t#2415) Signed-off-by: Xun Zhang <[email protected]>
…t#2415) Signed-off-by: Xun Zhang <[email protected]>
…t#2415) Signed-off-by: Xun Zhang <[email protected]>
Signed-off-by: Xun Zhang <[email protected]>
Signed-off-by: Xun Zhang <[email protected]>
…t#2415) (opensearch-project#2420) Signed-off-by: Xun Zhang <[email protected]>
Description
DeploySetting was not included in registering local models (pre-trained or from custom url), which was fine because it only included autoDeploy flag for remote models. Now we added TTL in the DeploySetting which applies to all models so We need to add it back.
Verified in local dev cluster.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.