Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: recover search index tool it in multi node cluster #2407

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Test: recover search index tool it in multi node cluster #2407

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
38f514c
implement search index tool it in multi node cluster
yuye-aws May 6, 2024
76039e9
implement search index tool it in multi node cluster
yuye-aws May 6, 2024
34f797b
spotless apply
yuye-aws May 6, 2024
a887afd
optimize if else
yuye-aws May 9, 2024
d49d906
update comment in IT
yuye-aws May 14, 2024
e9474dc
remove specific logic for multi-node
yuye-aws Jun 11, 2024
2ba6d69
recover error message
yuye-aws Jun 11, 2024
3d27e9f
recover error message
yuye-aws Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,6 @@ integTest {
// Set this to true this if you want to see the logs in the terminal test output.
// note: if left false the log output will still show in your IDE
testLogging.showStandardStreams = true

// Exclude integration test for search index tool for multiple nodes
// because we cannot get concrete exception message in multi-node cluster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a note why this section is commented out. How are we solving this issue then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are bringing back IT search index tool for multi node cluster.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging #2443 the issue has been resolved.

if (_numNodes > 1) {
filter {
excludeTestsMatching "org.opensearch.ml.rest.RestSearchIndexToolIT.*"
}
}
}

testClusters.integTest {
Expand Down
Loading