Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.13] remove checkstyle #2316

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[Backport 2.13] remove checkstyle #2316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ plugins {
id 'jacoco'
id 'java-library'
id 'com.diffplug.spotless' version '6.23.0'
id 'checkstyle'
}

ext {
Expand All @@ -31,10 +30,6 @@ ext {
noticeFile = rootProject.file('NOTICE')
}

checkstyle {
toolVersion = '10.12.2'
}

lombok {
version = "1.18.30"
}
Expand Down Expand Up @@ -64,8 +59,6 @@ dependencies {
implementation "org.apache.logging.log4j:log4j-slf4j-impl:2.19.0"
testImplementation group: 'commons-io', name: 'commons-io', version: '2.15.1'
implementation group: 'org.apache.commons', name: 'commons-text', version: '1.10.0'

checkstyle "com.puppycrawl.tools:checkstyle:${project.checkstyle.toolVersion}"
}

publishing {
Expand Down Expand Up @@ -110,14 +103,12 @@ compileJava {
//TODO: check which one should be enabled
licenseHeaders.enabled = true
testingConventions.enabled = false
checkstyleTest.enabled = false
forbiddenApis.ignoreFailures = false
dependencyLicenses.enabled = false
thirdPartyAudit.enabled = false
forbiddenApisTest.ignoreFailures = true
forbiddenApisMain.ignoreFailures = true
validateNebulaPom.enabled = false
checkstyleMain.enabled = false
loggerUsageCheck.enabled = false

def _numNodes = findProperty('numNodes') as Integer ?: 1
Expand Down
Loading