Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove checkstyle #2312

Merged
merged 1 commit into from
Apr 12, 2024
Merged

remove checkstyle #2312

merged 1 commit into from
Apr 12, 2024

Conversation

jngz-es
Copy link
Collaborator

@jngz-es jngz-es commented Apr 11, 2024

Description

  1. Remove checkstyle in favor of spotless.
  2. resolve Guava dependency conflicts between com.google.guava:guava:32.0.1-jre and com.google.guava:guava:32.1.2-jre.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jngz-es
remove checkstyle
958ef7a 
Signed-off-by: Jing Zhang <[email protected]>
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env April 11, 2024 23:19 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env April 11, 2024 23:19 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env April 11, 2024 23:20 — with GitHub Actions Error
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 11, 2024 23:20 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 11, 2024 23:20 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 11, 2024 23:20 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:09 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:09 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:09 — with GitHub Actions Inactive
@ylwu-amzn
Copy link
Collaborator

Why remove checkstyle ?

@jngz-es
Copy link
Collaborator Author

jngz-es commented Apr 12, 2024

@ylwu-amzn I added two points in the description.

@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:55 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:55 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:55 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:55 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:55 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:55 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:55 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:55 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env April 12, 2024 00:55 — with GitHub Actions Inactive
@jngz-es jngz-es merged commit 79b9dfd into opensearch-project:main Apr 12, 2024
15 checks passed
@jngz-es jngz-es deleted the builderror213 branch April 12, 2024 05:05
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 12, 2024
@jngz-es @github-actions
remove checkstyle (#2312)
bf05124 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 79b9dfd)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 12, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 12, 2024
@jngz-es @github-actions
remove checkstyle (#2312)
52be136 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 79b9dfd)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 12, 2024
Merged
jngz-es added a commit that referenced this pull request Apr 12, 2024
@opensearch-trigger-bot @jngz-es
remove checkstyle (#2312) (#2316)
aab729e 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 79b9dfd)

Co-authored-by: Jing Zhang <[email protected]>
jngz-es added a commit that referenced this pull request Apr 12, 2024
@opensearch-trigger-bot @jngz-es
remove checkstyle (#2312) (#2315)
d86603b 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 79b9dfd)

Co-authored-by: Jing Zhang <[email protected]>
@dhrubo-os
Copy link
Collaborator

While both tools can be part of a quality control pipeline in software development, they serve different purposes. Checkstyle is more about enforcing coding standards and best practices, while Spotless ensures that the code looks consistent without manually formatting it.

zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Apr 22, 2024
@opensearch-trigger-bot @jngz-es @zane-neo
remove checkstyle (opensearch-project#2312) (opensearch-project#2315)
e9ff645 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 79b9dfd)

Co-authored-by: Jing Zhang <[email protected]>
@mingshl mingshl added infra v2.13.0 Issues targeting release v2.13.0 labels Apr 30, 2024
dhrubo-os pushed a commit to dhrubo-os/ml-commons that referenced this pull request May 17, 2024
@opensearch-trigger-bot @jngz-es @dhrubo-os
remove checkstyle (opensearch-project#2312) (opensearch-project#2315)
ca53e59 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 79b9dfd)

Co-authored-by: Jing Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b4sjoo b4sjoo b4sjoo approved these changes

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.13 infra v2.13.0 Issues targeting release v2.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jngz-es @ylwu-amzn @dhrubo-os @b4sjoo @mingshl