-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check model auto deploy #2288
Merged
Merged
check model auto deploy #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhangxunmt
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
March 27, 2024 22:38
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
March 27, 2024 22:38 — with
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
March 27, 2024 22:38 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
March 27, 2024 22:38 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
March 27, 2024 22:39 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
March 27, 2024 22:39 — with
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
March 27, 2024 22:39 — with
GitHub Actions
Error
jngz-es
previously approved these changes
Mar 27, 2024
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 22:46 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 22:46 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 22:46 — with
GitHub Actions
Inactive
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
March 27, 2024 22:46 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
March 27, 2024 22:46 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
March 27, 2024 22:46 — with
GitHub Actions
Failure
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 22:51 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 22:51 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 22:51 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 22:51 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 22:51 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 22:51 — with
GitHub Actions
Inactive
b4sjoo
approved these changes
Mar 27, 2024
dhrubo-os
reviewed
Mar 27, 2024
listener | ||
.onFailure( | ||
new IllegalArgumentException( | ||
"Model not ready yet. Please run this first: POST /_plugins/_ml/models/" + modelId + "/_deploy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] We are assuming customer is using dev tools.
May be set a generic message like: "The model is not deployed yet. Please deploy the model first." ?
dhrubo-os
approved these changes
Mar 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 848abf6)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 848abf6)
Zhangxunmt
added a commit
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 848abf6) Co-authored-by: Xun Zhang <[email protected]>
Zhangxunmt
added a commit
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 848abf6) Co-authored-by: Xun Zhang <[email protected]>
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 23:41 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 23:41 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
March 27, 2024 23:41 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking if the model has auto-deploy enabled at the model level. If true, go ahead with auto deploy. Otherwise return 400 illegal_argument_exception with message asking Users to deploy model first.
If the deploy_setting is null in the Model, by default we treat it as true.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.