fix remote register model / circuit breaker 500 #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stener for register remote model Signed-off-by: Henry Lindeman <[email protected]>
HenryL27
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
sam-herman and
xinyual
as code owners
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
reviewed
Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2264 +/- ##
============================================
+ Coverage 81.40% 81.42% +0.01%
- Complexity 5851 5852 +1
============================================
Files 557 557
Lines 23877 23877
Branches 2494 2494
============================================
+ Hits 19437 19441 +4
+ Misses 3418 3414 -4
Partials 1022 1022
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: Henry Lindeman <[email protected]>
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
reviewed
Mar 22, 2024
plugin/src/test/java/org/opensearch/ml/model/MLModelManagerTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Henry Lindeman <[email protected]>
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
approved these changes
Mar 25, 2024
austintlee
approved these changes
Mar 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
* move memory CB check into try block to catch exception and hand to listener for register remote model Signed-off-by: Henry Lindeman <[email protected]> * add test that memory cb exception is caught by action listener Signed-off-by: Henry Lindeman <[email protected]> * unthrow priviledgedExceptionAction Signed-off-by: Henry Lindeman <[email protected]> --------- Signed-off-by: Henry Lindeman <[email protected]> (cherry picked from commit 30642e6)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
* move memory CB check into try block to catch exception and hand to listener for register remote model Signed-off-by: Henry Lindeman <[email protected]> * add test that memory cb exception is caught by action listener Signed-off-by: Henry Lindeman <[email protected]> * unthrow priviledgedExceptionAction Signed-off-by: Henry Lindeman <[email protected]> --------- Signed-off-by: Henry Lindeman <[email protected]> (cherry picked from commit 30642e6)
HenryL27
added a commit
that referenced
this pull request
Mar 25, 2024
* move memory CB check into try block to catch exception and hand to listener for register remote model Signed-off-by: Henry Lindeman <[email protected]> * add test that memory cb exception is caught by action listener Signed-off-by: Henry Lindeman <[email protected]> * unthrow priviledgedExceptionAction Signed-off-by: Henry Lindeman <[email protected]> --------- Signed-off-by: Henry Lindeman <[email protected]> (cherry picked from commit 30642e6) Co-authored-by: Henry Lindeman <[email protected]>
HenryL27
added a commit
that referenced
this pull request
Mar 25, 2024
* move memory CB check into try block to catch exception and hand to listener for register remote model Signed-off-by: Henry Lindeman <[email protected]> * add test that memory cb exception is caught by action listener Signed-off-by: Henry Lindeman <[email protected]> * unthrow priviledgedExceptionAction Signed-off-by: Henry Lindeman <[email protected]> --------- Signed-off-by: Henry Lindeman <[email protected]> (cherry picked from commit 30642e6) Co-authored-by: Henry Lindeman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On very rare occasion the memory circuit breaker triggers when registering a remote model. Before this PR, this would throw an exception, and because registerRemoteModel is a actionListener-based method, the error would be dropped and you get a 500 (internal server error) back. This PR moves the circuit breaker check inside the try block so that the exception is caught and 'actionListen'ed.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.