-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance connector helper notebook to support 2.9 #2202
Conversation
Signed-off-by: Yaliang Wu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works. But given that it applies to newer versions after 2.9, my concern is that it makes people think this "model_group" is totally a "chicken rib" because it shares the name with model name. And model name is mostly unique so it ends up with unique model name with a dedicated model group.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2202 +/- ##
=========================================
Coverage 81.91% 81.92%
- Complexity 5720 5722 +2
=========================================
Files 547 547
Lines 23064 23064
Branches 2378 2378
=========================================
+ Hits 18893 18895 +2
+ Misses 3227 3224 -3
- Partials 944 945 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Model group name is unique, but model name not. One model group can have multiple models with same model name. |
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit c233356)
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit c233356) Co-authored-by: Yaliang Wu <[email protected]>
@ylwu-amzn why do we need to have this when we have Flow framework which exactly does this right now? |
But we don't have flow framework on AWS now, right ? This is to help current AWS cx |
…2202) Signed-off-by: Yaliang Wu <[email protected]>
…2202) Signed-off-by: Yaliang Wu <[email protected]>
Description
enhance connector helper notebook to support 2.9
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.