Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance connector helper notebook to support 2.9 #2202

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

ylwu-amzn
Copy link
Collaborator

Description

enhance connector helper notebook to support 2.9

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@Zhangxunmt Zhangxunmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. But given that it applies to newer versions after 2.9, my concern is that it makes people think this "model_group" is totally a "chicken rib" because it shares the name with model name. And model name is mostly unique so it ends up with unique model name with a dedicated model group.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (9a913d6) to head (e181453).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2202   +/-   ##
=========================================
  Coverage     81.91%   81.92%           
- Complexity     5720     5722    +2     
=========================================
  Files           547      547           
  Lines         23064    23064           
  Branches       2378     2378           
=========================================
+ Hits          18893    18895    +2     
+ Misses         3227     3224    -3     
- Partials        944      945    +1     
Flag Coverage Δ
ml-commons 81.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env March 13, 2024 18:46 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env March 13, 2024 18:46 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env March 13, 2024 18:46 — with GitHub Actions Inactive
@ylwu-amzn
Copy link
Collaborator Author

And model name is mostly unique so it ends up with unique model name with a dedicated model group.

Model group name is unique, but model name not. One model group can have multiple models with same model name.

@ylwu-amzn ylwu-amzn merged commit c233356 into opensearch-project:main Mar 13, 2024
16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 13, 2024
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit c233356)
ylwu-amzn added a commit that referenced this pull request Mar 13, 2024
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit c233356)

Co-authored-by: Yaliang Wu <[email protected]>
@minalsha
Copy link

@ylwu-amzn why do we need to have this when we have Flow framework which exactly does this right now?

@ylwu-amzn
Copy link
Collaborator Author

@ylwu-amzn why do we need to have this when we have Flow framework which exactly does this right now?

But we don't have flow framework on AWS now, right ? This is to help current AWS cx

austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 18, 2024
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants