Enable conversation memory feature flags #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HenryL27 <[email protected]>
HenryL27
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
sam-herman
as code owners
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
previously approved these changes
Feb 13, 2024
dhrubo-os
previously approved these changes
Feb 13, 2024
|
@HenryL27 integration tests are failing. Could you please take a look at it? |
|
oh yes. we tested the feature flags. one sec |
Signed-off-by: HenryL27 <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
reviewed
Feb 13, 2024
Comment on lines
141
to
144
| Settings settings = Settings.builder().put(ConversationalIndexConstants.ML_COMMONS_MEMORY_FEATURE_ENABLED.getKey(), false).build(); | ||
| when(this.clusterService.getSettings()).thenReturn(settings); | ||
| when(this.clusterService.getClusterSettings()) | ||
| .thenReturn(new ClusterSettings(settings, Set.of(ConversationalIndexConstants.ML_COMMONS_MEMORY_FEATURE_ENABLED))); |
There was a problem hiding this comment.
This line seems redundant to all the files. Can't we put this in a common file (may be testutil or something) and then invoke this.
Signed-off-by: HenryL27 <[email protected]>
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
============================================
- Coverage 81.82% 81.82% -0.01%
+ Complexity 5617 5616 -1
============================================
Files 543 543
Lines 22810 22810
Branches 2339 2339
============================================
- Hits 18665 18664 -1
- Misses 3210 3213 +3
+ Partials 935 933 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
approved these changes
Feb 13, 2024
Zhangxunmt
approved these changes
Feb 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Enable conversation memory feature flags Signed-off-by: HenryL27 <[email protected]> * amend feature flag tests Signed-off-by: HenryL27 <[email protected]> * remove accidentally committed files Signed-off-by: HenryL27 <[email protected]> * apply spotless Signed-off-by: HenryL27 <[email protected]> * fix final feature disablement test. whoops Signed-off-by: HenryL27 <[email protected]> * move common feature disablement code to util class Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]> (cherry picked from commit 850c748)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Enable conversation memory feature flags Signed-off-by: HenryL27 <[email protected]> * amend feature flag tests Signed-off-by: HenryL27 <[email protected]> * remove accidentally committed files Signed-off-by: HenryL27 <[email protected]> * apply spotless Signed-off-by: HenryL27 <[email protected]> * fix final feature disablement test. whoops Signed-off-by: HenryL27 <[email protected]> * move common feature disablement code to util class Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]> (cherry picked from commit 850c748)
dhrubo-os
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Enable conversation memory feature flags Signed-off-by: HenryL27 <[email protected]> * amend feature flag tests Signed-off-by: HenryL27 <[email protected]> * remove accidentally committed files Signed-off-by: HenryL27 <[email protected]> * apply spotless Signed-off-by: HenryL27 <[email protected]> * fix final feature disablement test. whoops Signed-off-by: HenryL27 <[email protected]> * move common feature disablement code to util class Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]> (cherry picked from commit 850c748) Co-authored-by: HenryL27 <[email protected]>
Zhangxunmt
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Enable conversation memory feature flags Signed-off-by: HenryL27 <[email protected]> * amend feature flag tests Signed-off-by: HenryL27 <[email protected]> * remove accidentally committed files Signed-off-by: HenryL27 <[email protected]> * apply spotless Signed-off-by: HenryL27 <[email protected]> * fix final feature disablement test. whoops Signed-off-by: HenryL27 <[email protected]> * move common feature disablement code to util class Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]> (cherry picked from commit 850c748) Co-authored-by: HenryL27 <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
* Enable conversation memory feature flags Signed-off-by: HenryL27 <[email protected]> * amend feature flag tests Signed-off-by: HenryL27 <[email protected]> * remove accidentally committed files Signed-off-by: HenryL27 <[email protected]> * apply spotless Signed-off-by: HenryL27 <[email protected]> * fix final feature disablement test. whoops Signed-off-by: HenryL27 <[email protected]> * move common feature disablement code to util class Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable feature flags for GA conversation search in 2.12
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.