add tutorial for conversational search #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
============================================
- Coverage 81.81% 81.79% -0.03%
+ Complexity 5617 5614 -3
============================================
Files 543 543
Lines 22796 22796
Branches 2337 2337
============================================
- Hits 18651 18646 -5
- Misses 3209 3215 +6
+ Partials 936 935 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
previously approved these changes
Feb 12, 2024
ylwu-amzn
commented
Feb 12, 2024
| @@ -0,0 +1,395 @@ | |||
| # Topic | |||
|
|
|||
| > Agent Framework is an experimental feature released in OpenSearch 2.12 and not recommended for use in a production environment. For updates on the progress of the feature or if you want to leave feedback, see the associated [GitHub issue](https://github.com/opensearch-project/ml-commons/issues/1161). | |||
There was a problem hiding this comment.
OpenSearch 2.12 not released yet. If you want to try this feature now, you can use the latest RC opensearch-project/opensearch-build#4115 (comment)
HenryL27
reviewed
Feb 12, 2024
| "plugins.ml_commons.only_run_on_ml_node": false, | ||
| "plugins.ml_commons.native_memory_threshold": 100, | ||
| "plugins.ml_commons.agent_framework_enabled": true, | ||
| "plugins.ml_commons.memory_feature_enabled": true |
There was a problem hiding this comment.
isn't this enabled by default now?
There was a problem hiding this comment.
(memory_feature_enabled - didn't mean to highlight all that)
There was a problem hiding this comment.
Checkd code, it's still disabled, @Zhangxunmt can you enable these once all security issues fixed ? We can remove this part later when it's enabled by default.
mingshl
reviewed
Feb 12, 2024
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
approved these changes
Feb 13, 2024
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
approved these changes
Feb 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
* add tutorial for conversational search Signed-off-by: Yaliang Wu <[email protected]> * add more doc links Signed-off-by: Yaliang Wu <[email protected]> * add advanced topics Signed-off-by: Yaliang Wu <[email protected]> * add demo of PPLTool Signed-off-by: Yaliang Wu <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> * remvoe unnecessary setting Signed-off-by: Yaliang Wu <[email protected]> * use memory/message to keep consistent Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit 7ecc695)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
* add tutorial for conversational search Signed-off-by: Yaliang Wu <[email protected]> * add more doc links Signed-off-by: Yaliang Wu <[email protected]> * add advanced topics Signed-off-by: Yaliang Wu <[email protected]> * add demo of PPLTool Signed-off-by: Yaliang Wu <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> * remvoe unnecessary setting Signed-off-by: Yaliang Wu <[email protected]> * use memory/message to keep consistent Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit 7ecc695)
ylwu-amzn
added a commit
that referenced
this pull request
Feb 13, 2024
* add tutorial for conversational search Signed-off-by: Yaliang Wu <[email protected]> * add more doc links Signed-off-by: Yaliang Wu <[email protected]> * add advanced topics Signed-off-by: Yaliang Wu <[email protected]> * add demo of PPLTool Signed-off-by: Yaliang Wu <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> * remvoe unnecessary setting Signed-off-by: Yaliang Wu <[email protected]> * use memory/message to keep consistent Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit 7ecc695) Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn
added a commit
that referenced
this pull request
Feb 13, 2024
* add tutorial for conversational search Signed-off-by: Yaliang Wu <[email protected]> * add more doc links Signed-off-by: Yaliang Wu <[email protected]> * add advanced topics Signed-off-by: Yaliang Wu <[email protected]> * add demo of PPLTool Signed-off-by: Yaliang Wu <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> * remvoe unnecessary setting Signed-off-by: Yaliang Wu <[email protected]> * use memory/message to keep consistent Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit 7ecc695) Co-authored-by: Yaliang Wu <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
* add tutorial for conversational search Signed-off-by: Yaliang Wu <[email protected]> * add more doc links Signed-off-by: Yaliang Wu <[email protected]> * add advanced topics Signed-off-by: Yaliang Wu <[email protected]> * add demo of PPLTool Signed-off-by: Yaliang Wu <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> * remvoe unnecessary setting Signed-off-by: Yaliang Wu <[email protected]> * use memory/message to keep consistent Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> Co-authored-by: kolchfa-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.