enhance: make response_field customizable in MLModelTool #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2007 +/- ##
============================================
- Coverage 82.57% 82.56% -0.02%
+ Complexity 5577 5575 -2
============================================
Files 540 540
Lines 22453 22456 +3
Branches 2286 2286
============================================
Hits 18540 18540
- Misses 2981 2985 +4
+ Partials 932 931 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhichao-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zhichao-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
zhichao-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
|
@ylwu-amzn @dhrubo-os Do you think this PR is enough to fix this problem? Please help review thanks |
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
model-collapse
approved these changes
Feb 7, 2024
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Feb 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* enhance: make response_field customizable in MLModelTool Signed-off-by: zhichao-aws <[email protected]> * ut for malformed response field Signed-off-by: zhichao-aws <[email protected]> * remove import * in MLModelToolTests Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit e1d21ba)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* enhance: make response_field customizable in MLModelTool Signed-off-by: zhichao-aws <[email protected]> * ut for malformed response field Signed-off-by: zhichao-aws <[email protected]> * remove import * in MLModelToolTests Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit e1d21ba)
This was referenced Feb 7, 2024
ylwu-amzn
pushed a commit
that referenced
this pull request
Feb 7, 2024
* enhance: make response_field customizable in MLModelTool Signed-off-by: zhichao-aws <[email protected]> * ut for malformed response field Signed-off-by: zhichao-aws <[email protected]> * remove import * in MLModelToolTests Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit e1d21ba) Co-authored-by: zhichao-aws <[email protected]>
ylwu-amzn
pushed a commit
that referenced
this pull request
Feb 7, 2024
* enhance: make response_field customizable in MLModelTool Signed-off-by: zhichao-aws <[email protected]> * ut for malformed response field Signed-off-by: zhichao-aws <[email protected]> * remove import * in MLModelToolTests Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit e1d21ba) Co-authored-by: zhichao-aws <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…project#2007) * enhance: make response_field customizable in MLModelTool Signed-off-by: zhichao-aws <[email protected]> * ut for malformed response field Signed-off-by: zhichao-aws <[email protected]> * remove import * in MLModelToolTests Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current MLModelTool hard code to fetch the
responsefield from response body. However, in other non-LLM cases or non-Claude LLM services, we can not assume all of them useresponsekeyword.This PR makes response_field customizable in MLModelTool. If not provided, it will use
responseby default. This will make current API invokation behavior consistent.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.