Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if model id is null when undeploy #2006

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

ylwu-amzn
Copy link
Collaborator

Description

check if model id is null when undeploy

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b84b130) 82.57% compared to head (a822169) 82.53%.

Files Patch % Lines
...action/undeploy/TransportUndeployModelsAction.java 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2006      +/-   ##
============================================
- Coverage     82.57%   82.53%   -0.04%     
+ Complexity     5577     5574       -3     
============================================
  Files           540      540              
  Lines         22453    22456       +3     
  Branches       2286     2287       +1     
============================================
- Hits          18540    18534       -6     
- Misses         2981     2989       +8     
- Partials        932      933       +1     
Flag Coverage Δ
ml-commons 82.53% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 4, 2024 03:15 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 4, 2024 03:15 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 4, 2024 03:15 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt merged commit 2c63e8d into opensearch-project:main Feb 5, 2024
11 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 5, 2024
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 2c63e8d)
ylwu-amzn added a commit that referenced this pull request Feb 5, 2024
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 2c63e8d)

Co-authored-by: Yaliang Wu <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants