Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent framework disable/enable flag #1949

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jngz-es
Copy link
Collaborator

@jngz-es jngz-es commented Jan 29, 2024

Description

Add a setting to enable/disable agent framework feature. Currently the setting is set to false by default.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d0895bb) 82.94% compared to head (794d569) 82.93%.
Report is 9 commits behind head on main.

Files Patch % Lines
...pensearch/ml/settings/MLFeatureEnabledSetting.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1949      +/-   ##
============================================
- Coverage     82.94%   82.93%   -0.02%     
- Complexity     5414     5415       +1     
============================================
  Files           521      521              
  Lines         21709    21735      +26     
  Branches       2213     2214       +1     
============================================
+ Hits          18007    18026      +19     
- Misses         2807     2813       +6     
- Partials        895      896       +1     
Flag Coverage Δ
ml-commons 82.93% <97.22%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env January 29, 2024 19:51 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env January 29, 2024 19:51 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env January 29, 2024 19:51 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit f70b433 into opensearch-project:main Feb 2, 2024
11 of 15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 2, 2024
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit f70b433)
mingshl pushed a commit that referenced this pull request Feb 2, 2024
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit f70b433)

Co-authored-by: Jing Zhang <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
@jngz-es jngz-es deleted the agent_disable branch March 19, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants