Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate node if node has both data and ml role #1829

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

ylwu-amzn
Copy link
Collaborator

Description

If a node has both data and ml role, the eligible nodes will have duplicate node ids. Then deploy model will fail on the duplicate node.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (741d4da) 82.49% compared to head (174fdae) 82.50%.

Files Patch % Lines
...org/opensearch/ml/cluster/DiscoveryNodeHelper.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1829   +/-   ##
=========================================
  Coverage     82.49%   82.50%           
- Complexity     5316     5318    +2     
=========================================
  Files           510      510           
  Lines         21446    21446           
  Branches       2202     2202           
=========================================
+ Hits          17691    17693    +2     
+ Misses         2861     2858    -3     
- Partials        894      895    +1     
Flag Coverage Δ
ml-commons 82.50% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 2, 2024 19:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 2, 2024 19:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 2, 2024 19:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 2, 2024 19:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env January 2, 2024 19:47 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 2, 2024 20:14 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 2, 2024 20:14 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 2, 2024 20:14 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 2, 2024 20:14 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env January 2, 2024 20:14 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn merged commit 169df62 into opensearch-project:main Jan 2, 2024
10 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 2, 2024
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 169df62)
mingshl pushed a commit that referenced this pull request Jan 2, 2024
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 169df62)

Co-authored-by: Yaliang Wu <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants