-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix duplicate node if node has both data and ml role #1829
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
December 30, 2023 10:20
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
December 30, 2023 10:20 — with
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
December 30, 2023 10:20 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
December 30, 2023 10:20 — with
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
December 30, 2023 10:20 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
December 30, 2023 10:20 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
December 30, 2023 10:20 — with
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1829 +/- ##
=========================================
Coverage 82.49% 82.50%
- Complexity 5316 5318 +2
=========================================
Files 510 510
Lines 21446 21446
Branches 2202 2202
=========================================
+ Hits 17691 17693 +2
+ Misses 2861 2858 -3
- Partials 894 895 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
December 30, 2023 10:43 — with
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
December 30, 2023 10:43 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
December 30, 2023 10:43 — with
GitHub Actions
Error
b4sjoo
approved these changes
Jan 2, 2024
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
January 2, 2024 19:47 — with
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 19:47 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 19:47 — with
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
January 2, 2024 19:47 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
January 2, 2024 19:47 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
January 2, 2024 19:47 — with
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 19:47 — with
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 19:47 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 19:47 — with
GitHub Actions
Error
rbhavna
approved these changes
Jan 2, 2024
mingshl
approved these changes
Jan 2, 2024
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
January 2, 2024 20:14 — with
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 20:14 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 20:14 — with
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
January 2, 2024 20:14 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
January 2, 2024 20:14 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
January 2, 2024 20:14 — with
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 20:14 — with
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 20:14 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
January 2, 2024 20:14 — with
GitHub Actions
Error
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 2, 2024
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 169df62)
mingshl
pushed a commit
that referenced
this pull request
Jan 2, 2024
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 169df62) Co-authored-by: Yaliang Wu <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…ect#1829) Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a node has both
data
andml
role, the eligible nodes will have duplicate node ids. Then deploy model will fail on the duplicate node.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.