Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] agent meta classes in common #1759

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3949ef9 from #1757

* agent meta classes

Signed-off-by: Jing Zhang <[email protected]>

* address comments

Signed-off-by: Jing Zhang <[email protected]>

* add one more UT

Signed-off-by: Jing Zhang <[email protected]>

* add more UT

Signed-off-by: Jing Zhang <[email protected]>

* more UT

Signed-off-by: Jing Zhang <[email protected]>

---------

Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 3949ef9)
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (a881bc7) 82.40% compared to head (dc77c4d) 82.47%.

Files Patch % Lines
...n/java/org/opensearch/ml/common/agent/MLAgent.java 88.73% 2 Missing and 14 partials ⚠️
...ava/org/opensearch/ml/common/agent/MLToolSpec.java 86.95% 2 Missing and 7 partials ⚠️
...ain/java/org/opensearch/ml/common/CommonValue.java 0.00% 6 Missing ⚠️
...a/org/opensearch/ml/common/agent/MLMemorySpec.java 87.23% 2 Missing and 4 partials ⚠️
...n/java/org/opensearch/ml/common/agent/LLMSpec.java 88.37% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1759      +/-   ##
============================================
+ Coverage     82.40%   82.47%   +0.06%     
- Complexity     4467     4529      +62     
============================================
  Files           425      429       +4     
  Lines         17764    18071     +307     
  Branches       1883     1931      +48     
============================================
+ Hits          14639    14904     +265     
- Misses         2360     2373      +13     
- Partials        765      794      +29     
Flag Coverage Δ
ml-commons 82.47% <86.31%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zhangxunmt Zhangxunmt merged commit 0a1b4b5 into 2.x Dec 13, 2023
9 of 15 checks passed
@github-actions github-actions bot deleted the backport/backport-1757-to-2.x branch December 13, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants