[Backport 2.x] Add cross encoder support #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* add text similarity inputs and function name Signed-off-by: HenryL27 <[email protected]> * add text similarity cross encoder model Signed-off-by: HenryL27 <[email protected]> * add text similarity unit tests Signed-off-by: HenryL27 <[email protected]> * add text similarity input unittests Signed-off-by: HenryL27 <[email protected]> * add text similarity dataset unittests Signed-off-by: HenryL27 <[email protected]> * add function name annotation Signed-off-by: HenryL27 <[email protected]> * refactor API to use single query Signed-off-by: HenryL27 <[email protected]> * omit private from class vars Co-authored-by: Navneet Verma <[email protected]> Signed-off-by: HenryL27 <[email protected]> * change output name from logits to similarity Signed-off-by: HenryL27 <[email protected]> * hashify isDLModel Signed-off-by: HenryL27 <[email protected]> * add error message for non-torchscript cross encoders Signed-off-by: HenryL27 <[email protected]> * allow onnx, actually. Signed-off-by: HenryL27 <[email protected]> * apply spotless after rebase Signed-off-by: HenryL27 <[email protected]> * add unittest for new mlinput toXcontent clause Signed-off-by: HenryL27 <[email protected]> * static DLModels Signed-off-by: HenryL27 <[email protected]> * add tests and error message tweaks Signed-off-by: HenryL27 <[email protected]> * name test models w framework Signed-off-by: HenryL27 <[email protected]> * change pt->torch_script Signed-off-by: HenryL27 <[email protected]> --------- Signed-off-by: HenryL27 <[email protected]> Co-authored-by: Navneet Verma <[email protected]> (cherry picked from commit 2761d7d)
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1739 +/- ##
============================================
+ Coverage 81.19% 81.33% +0.14%
- Complexity 4343 4375 +32
============================================
Files 421 425 +4
Lines 17333 17478 +145
Branches 1832 1849 +17
============================================
+ Hits 14073 14216 +143
+ Misses 2543 2537 -6
- Partials 717 725 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
HenryL27
approved these changes
Dec 7, 2023
dhrubo-os
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2761d7d from #1615