Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get model group API #1670

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Nov 21, 2023

Description

Get model group API using model_group_id

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 21, 2023 15:17 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 21, 2023 15:17 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 22, 2023 18:19 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 22, 2023 18:19 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env November 22, 2023 18:40 — with GitHub Actions Inactive
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 22, 2023 18:40 — with GitHub Actions Failure
@Builder
public MLModelGroupGetRequest(String modelGroupId, boolean returnContent) {
this.modelGroupId = modelGroupId;
this.returnContent = returnContent;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this parameter? Can you add some example request/response to the description part?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not need this. This is mostly related to model content. Removing this for model group API

@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env November 22, 2023 18:54 — with GitHub Actions Inactive
Signed-off-by: Bhavana Ramaram <[email protected]>
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 27, 2023 21:05 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env November 27, 2023 21:05 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env November 27, 2023 21:05 — with GitHub Actions Inactive
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 27, 2023 21:05 — with GitHub Actions Failure
@rbhavna rbhavna merged commit 500fff9 into opensearch-project:main Nov 27, 2023
8 of 12 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1670-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 500fff9e333b593695c4e5072709356e6e24d31d
# Push it to GitHub
git push --set-upstream origin backport/backport-1670-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1670-to-2.x.

rbhavna added a commit to rbhavna/ml-commons that referenced this pull request Nov 27, 2023
* Get model group API

Signed-off-by: Bhavana Ramaram <[email protected]>
(cherry picked from commit 500fff9)
@rbhavna rbhavna mentioned this pull request Nov 27, 2023
5 tasks
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1670-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 500fff9e333b593695c4e5072709356e6e24d31d
# Push it to GitHub
git push --set-upstream origin backport/backport-1670-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1670-to-2.x.

rbhavna added a commit to rbhavna/ml-commons that referenced this pull request Nov 27, 2023
* Get model group API

Signed-off-by: Bhavana Ramaram <[email protected]>
rbhavna added a commit to rbhavna/ml-commons that referenced this pull request Nov 28, 2023
* Get model group API

Signed-off-by: Bhavana Ramaram <[email protected]>
dhrubo-os pushed a commit that referenced this pull request Nov 28, 2023
* Get model group API

Signed-off-by: Bhavana Ramaram <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
* Get model group API

Signed-off-by: Bhavana Ramaram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants