Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to main] update connector API #1651

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Nov 16, 2023

Description

Backport 1227 to main

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (568bc7e) 79.42% compared to head (d73e3e5) 79.65%.
Report is 3 commits behind head on main.

Files Patch % Lines
...rithms/metrics_correlation/MetricsCorrelation.java 0.00% 46 Missing ⚠️
...pensearch/ml/engine/algorithms/DLModelExecute.java 0.00% 10 Missing ⚠️
.../ml/engine/algorithms/clustering/RCFSummarize.java 78.94% 7 Missing and 1 partial ⚠️
...ain/java/org/opensearch/ml/engine/ModelHelper.java 78.26% 4 Missing and 1 partial ⚠️
..._embedding/HuggingfaceTextEmbeddingTranslator.java 33.33% 4 Missing ⚠️
...gine/algorithms/tokenize/SparseTokenizerModel.java 78.57% 2 Missing and 1 partial ⚠️
...n/transport/connector/MLUpdateConnectorAction.java 0.00% 2 Missing ⚠️
...l/engine/algorithms/ad/AnomalyDetectionLibSVM.java 87.50% 0 Missing and 2 partials ⚠️
...thms/anomalylocalization/AnomalyLocalizerImpl.java 96.66% 0 Missing and 2 partials ⚠️
...rics_correlation/MetricsCorrelationTranslator.java 0.00% 2 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1651      +/-   ##
============================================
+ Coverage     79.42%   79.65%   +0.23%     
- Complexity     3982     4017      +35     
============================================
  Files           390      394       +4     
  Lines         16215    16385     +170     
  Branches       1751     1754       +3     
============================================
+ Hits          12879    13052     +173     
+ Misses         2661     2657       -4     
- Partials        675      676       +1     
Flag Coverage Δ
ml-commons 79.65% <83.46%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbhavna rbhavna merged commit 5759bf2 into opensearch-project:main Nov 16, 2023
9 of 15 checks passed
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
* update connector API

Signed-off-by: Xun Zhang <[email protected]>

* more ut test coverage

Signed-off-by: Xun Zhang <[email protected]>

* check connector usage in deployed models before updating connector

Signed-off-by: Xun Zhang <[email protected]>

---------

Signed-off-by: Xun Zhang <[email protected]>
Co-authored-by: Xun Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants