Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Read function Name from pretrained model (#1529) #1638

Merged

Conversation

xinyual
Copy link
Collaborator

@xinyual xinyual commented Nov 15, 2023

Description

backport pr for #1529

Issues Resolved

backport pr for #1529

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@xinyual xinyual had a problem deploying to ml-commons-cicd-env November 15, 2023 01:09 — with GitHub Actions Failure
@xinyual xinyual temporarily deployed to ml-commons-cicd-env November 15, 2023 01:09 — with GitHub Actions Inactive
@xinyual xinyual temporarily deployed to ml-commons-cicd-env November 15, 2023 01:09 — with GitHub Actions Inactive
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6efb1eb) 80.72% compared to head (01deeb7) 80.74%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1638      +/-   ##
============================================
+ Coverage     80.72%   80.74%   +0.02%     
- Complexity     4181     4183       +2     
============================================
  Files           399      399              
  Lines         16816    16822       +6     
  Branches       1815     1815              
============================================
+ Hits          13574    13583       +9     
+ Misses         2527     2522       -5     
- Partials        715      717       +2     
Flag Coverage Δ
ml-commons 80.74% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn
Copy link
Collaborator

Make the commit message more readable
[Backport 2.x] Read function Name from pretrained model (#1529) ?

@ylwu-amzn
Copy link
Collaborator

After merging 2.11 backport PR, the commit history is not readable https://github.com/opensearch-project/ml-commons/commits/2.11
From the message backport to 2.11, it's hard to tell what's this commit for.

Screenshot 2023-11-14 at 5 30 46 PM

@xinyual
Copy link
Collaborator Author

xinyual commented Nov 15, 2023

Make the commit message more readable [Backport 2.x] Read function Name from pretrained model (#1529) ?

Ok. Will do so. Sorry for the mistake.

@xinyual xinyual force-pushed the backport/backport-1529-to-2.x branch from 94713cb to 01deeb7 Compare November 15, 2023 01:42
@xinyual xinyual had a problem deploying to ml-commons-cicd-env November 15, 2023 01:42 — with GitHub Actions Failure
@xinyual xinyual temporarily deployed to ml-commons-cicd-env November 15, 2023 01:42 — with GitHub Actions Inactive
@xinyual xinyual temporarily deployed to ml-commons-cicd-env November 15, 2023 01:42 — with GitHub Actions Inactive
@xinyual
Copy link
Collaborator Author

xinyual commented Nov 15, 2023

Force push to make commit readable.

@ylwu-amzn ylwu-amzn changed the title backport to 2.x for PR 1529 [Backport 2.x] Read function Name from pretrained model (#1529) Nov 15, 2023
@xinyual xinyual had a problem deploying to ml-commons-cicd-env November 15, 2023 02:04 — with GitHub Actions Failure
@zane-neo zane-neo merged commit 56f1663 into opensearch-project:2.x Nov 15, 2023
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants