Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing MachineLearningNodeClient create connector, deploy model, register model group actions #1580

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

joshpalis
Copy link
Member

Description

Following PR #1560, additional class casting issues have been observed for create connector, deploy model, register model group.

This PR resolves those issues

Issues Resolved

Coming from opensearch-project/flow-framework#131
Continuation of #1553

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshpalis
Copy link
Member Author

@ylwu-amzn This PR, along with the following PRs need to be backported to the agent_framework feature branch. Flow framework plugin 2.x will be tracking ML-Commons agent_framework instead of 2.x as per this issue. Can you assist in creating and applying the backport label

PRs :

@joshpalis joshpalis temporarily deployed to ml-commons-cicd-env November 1, 2023 21:42 — with GitHub Actions Inactive
@joshpalis joshpalis temporarily deployed to ml-commons-cicd-env November 2, 2023 19:02 — with GitHub Actions Inactive
@joshpalis joshpalis temporarily deployed to ml-commons-cicd-env November 2, 2023 19:02 — with GitHub Actions Inactive
@joshpalis joshpalis temporarily deployed to ml-commons-cicd-env November 2, 2023 19:47 — with GitHub Actions Inactive
@joshpalis joshpalis temporarily deployed to ml-commons-cicd-env November 2, 2023 19:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit 882246c into opensearch-project:main Nov 2, 2023
6 of 10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to feature/agent_framework_dev failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-feature/agent_framework_dev feature/agent_framework_dev
# Navigate to the new working tree
cd .worktrees/backport-feature/agent_framework_dev
# Create a new branch
git switch --create backport/backport-1580-to-feature/agent_framework_dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 882246c04daacc98eb9c72fbdcabcce497856423
# Push it to GitHub
git push --set-upstream origin backport/backport-1580-to-feature/agent_framework_dev
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-feature/agent_framework_dev

Then, create a pull request where the base branch is feature/agent_framework_dev and the compare/head branch is backport/backport-1580-to-feature/agent_framework_dev.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2023
…ster model group actions (#1580)

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 882246c)
dhrubo-os pushed a commit that referenced this pull request Nov 2, 2023
…ster model group actions (#1580) (#1584)

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 882246c)

Co-authored-by: Joshua Palis <[email protected]>
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 6, 2023
…ster model group actions (opensearch-project#1580)

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 6, 2023
…ster model group actions (opensearch-project#1580)

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants