Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bakport to 2.9] Backport multiple PRs to 2.9 #1434

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Backport PRs to 2.9
#1427
#1407
#1274
#1362

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ylwu-amzn and others added 4 commits October 3, 2023 22:27
opensearch-project#1362)

* fix parameter name in preprocess function; fix remote model function name

Signed-off-by: Yaliang Wu <[email protected]>

* fix failed unit test

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
…pensearch-project#1274)

* Fix breaking change caused by opensearch core

Signed-off-by: zane-neo <[email protected]>

* Add neural search default pre/post process function support

Signed-off-by: zane-neo <[email protected]>

* Fix UT failures

Signed-off-by: zane-neo <[email protected]>

* Fix conflicts when backport

Signed-off-by: zane-neo <[email protected]>

* Fix conflict when backport

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
* support bwc for process function

Signed-off-by: Yaliang Wu <[email protected]>

* add comment

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 4, 2023 21:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 4, 2023 21:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env October 4, 2023 21:47 — with GitHub Actions Failure
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1434 (6961db7) into 2.9 (1b33d6d) will decrease coverage by 0.15%.
The diff coverage is 55.07%.

@@             Coverage Diff              @@
##                2.9    #1434      +/-   ##
============================================
- Coverage     78.76%   78.61%   -0.15%     
+ Complexity     2161     2160       -1     
============================================
  Files           168      168              
  Lines          8775     8779       +4     
  Branches        878      879       +1     
============================================
- Hits           6912     6902      -10     
- Misses         1462     1477      +15     
+ Partials        401      400       -1     
Flag Coverage Δ
ml-commons 78.61% <55.07%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ain/java/org/opensearch/ml/engine/ModelHelper.java 89.92% <ø> (-0.08%) ⬇️
...va/org/opensearch/ml/engine/utils/ScriptUtils.java 90.00% <100.00%> (+13.52%) ⬆️
...ine/algorithms/remote/RemoteConnectorExecutor.java 88.46% <66.66%> (+1.79%) ⬆️
...va/org/opensearch/ml/task/MLPredictTaskRunner.java 82.63% <66.66%> (+1.81%) ⬆️
...ch/ml/engine/algorithms/remote/ConnectorUtils.java 59.78% <52.45%> (-11.84%) ⬇️

... and 1 file with indirect coverage changes

@ylwu-amzn ylwu-amzn merged commit 285f71b into opensearch-project:2.9 Oct 4, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants