Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] fix system index access bug #1272 (#1320) #1431

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

HenryL27
Copy link
Collaborator

@HenryL27 HenryL27 commented Oct 4, 2023

(cherry picked from commit 8cdac91)

Description

PR 2/4 bringing conversation feature to main

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ct#1320)

Signed-off-by: HenryL27 <[email protected]>
(cherry picked from commit 8cdac91)
Signed-off-by: HenryL27 <[email protected]>
@HenryL27 HenryL27 temporarily deployed to ml-commons-cicd-env October 4, 2023 19:53 — with GitHub Actions Inactive
@HenryL27 HenryL27 temporarily deployed to ml-commons-cicd-env October 4, 2023 19:53 — with GitHub Actions Inactive
@HenryL27 HenryL27 had a problem deploying to ml-commons-cicd-env October 4, 2023 19:53 — with GitHub Actions Failure
@HenryL27 HenryL27 temporarily deployed to ml-commons-cicd-env October 4, 2023 19:53 — with GitHub Actions Inactive
@HenryL27 HenryL27 temporarily deployed to ml-commons-cicd-env October 4, 2023 19:53 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1431 (0955580) into main (6e0d949) will increase coverage by 0.59%.
Report is 2 commits behind head on main.
The diff coverage is 94.01%.

@@             Coverage Diff              @@
##               main    #1431      +/-   ##
============================================
+ Coverage     77.44%   78.04%   +0.59%     
- Complexity     2178     2283     +105     
============================================
  Files           173      193      +20     
  Lines          8984     9317     +333     
  Branches        892      918      +26     
============================================
+ Hits           6958     7271     +313     
- Misses         1620     1633      +13     
- Partials        406      413       +7     
Flag Coverage Δ
ml-commons 78.04% <94.01%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ch/ml/rest/RestMemoryCreateConversationAction.java 100.00% <100.00%> (ø)
...rch/ml/rest/RestMemoryCreateInteractionAction.java 100.00% <100.00%> (ø)
...ch/ml/rest/RestMemoryDeleteConversationAction.java 100.00% <100.00%> (ø)
...arch/ml/rest/RestMemoryGetConversationsAction.java 100.00% <100.00%> (ø)
...earch/ml/rest/RestMemoryGetInteractionsAction.java 100.00% <100.00%> (ø)
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <100.00%> (ø)
...ering/generative/GenerativeQARequestProcessor.java 100.00% <100.00%> (ø)
...answering/generative/GenerativeSearchResponse.java 100.00% <100.00%> (ø)
...ng/generative/ext/GenerativeQAParamExtBuilder.java 100.00% <100.00%> (ø)
...swering/generative/ext/GenerativeQAParameters.java 100.00% <100.00%> (ø)
... and 12 more

... and 2 files with indirect coverage changes

@dhrubo-os dhrubo-os merged commit 0cd5de4 into opensearch-project:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants