Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bedrock blueprint doc #1429

Merged
merged 2 commits into from
Oct 5, 2023
Merged

add bedrock blueprint doc #1429

merged 2 commits into from
Oct 5, 2023

Conversation

jhart0
Copy link
Contributor

@jhart0 jhart0 commented Oct 4, 2023 •
edited
Loading

Description

This commit adds an example blueprint for using Amazon Bedrock within Opensearch

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jhart0 jhart0 temporarily deployed to ml-commons-cicd-env October 4, 2023 14:00 — with GitHub Actions Inactive
@jhart0 jhart0 had a problem deploying to ml-commons-cicd-env October 4, 2023 14:00 — with GitHub Actions Error
@jhart0 jhart0 temporarily deployed to ml-commons-cicd-env October 4, 2023 14:00 — with GitHub Actions Inactive
@jhart0 jhart0 had a problem deploying to ml-commons-cicd-env October 4, 2023 14:00 — with GitHub Actions Failure
@jhart0 jhart0 had a problem deploying to ml-commons-cicd-env October 4, 2023 14:00 — with GitHub Actions Error
@jhart0 jhart0 had a problem deploying to ml-commons-cicd-env October 4, 2023 14:00 — with GitHub Actions Failure
@jhart0
add bedrock blueprint doc
8a97720 
Signed-off-by: Josh Hart <[email protected]>
@jhart0 jhart0 had a problem deploying to ml-commons-cicd-env October 4, 2023 14:06 — with GitHub Actions Error
@jhart0 jhart0 temporarily deployed to ml-commons-cicd-env October 4, 2023 14:06 — with GitHub Actions Inactive
@jhart0 jhart0 had a problem deploying to ml-commons-cicd-env October 4, 2023 14:06 — with GitHub Actions Failure
@jhart0 jhart0 had a problem deploying to ml-commons-cicd-env October 4, 2023 14:06 — with GitHub Actions Error
@jhart0 jhart0 had a problem deploying to ml-commons-cicd-env October 4, 2023 14:06 — with GitHub Actions Error
@jhart0 jhart0 had a problem deploying to ml-commons-cicd-env October 4, 2023 14:06 — with GitHub Actions Failure
@jhart0
add 2 versions of connector blueprint: one for self-managed and one f…
352c411 
…or using the AWS managed service

Signed-off-by: Josh Hart <[email protected]>
@jhart0 jhart0 temporarily deployed to ml-commons-cicd-env October 4, 2023 17:08 — with GitHub Actions Inactive
@jhart0 jhart0 temporarily deployed to ml-commons-cicd-env October 4, 2023 17:08 — with GitHub Actions Inactive
@jhart0 jhart0 temporarily deployed to ml-commons-cicd-env October 4, 2023 17:08 — with GitHub Actions Inactive
@jhart0 jhart0 temporarily deployed to ml-commons-cicd-env October 4, 2023 17:08 — with GitHub Actions Inactive
@jhart0 jhart0 temporarily deployed to ml-commons-cicd-env October 4, 2023 17:08 — with GitHub Actions Inactive
@jhart0 jhart0 temporarily deployed to ml-commons-cicd-env October 4, 2023 17:08 — with GitHub Actions Inactive
@jhart0 jhart0 requested a review from ylwu-amzn October 4, 2023 17:14
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #1429 (352c411) into main (6e0d949) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1429      +/-   ##
============================================
+ Coverage     77.44%   77.51%   +0.06%     
- Complexity     2178     2180       +2     
============================================
  Files           173      173              
  Lines          8984     8984              
  Branches        892      892              
============================================
+ Hits           6958     6964       +6     
+ Misses         1620     1616       -4     
+ Partials        406      404       -2
Flag Coverage Δ
ml-commons 77.51% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

ylwu-amzn
ylwu-amzn approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this!

@ylwu-amzn ylwu-amzn merged commit ed6b080 into opensearch-project:main Oct 5, 2023
10 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 12, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2023
@jhart0 @github-actions
add bedrock blueprint doc (#1429)
b2c1117 
* add bedrock blueprint doc
Signed-off-by: Josh Hart <[email protected]>

* add 2 versions of connector blueprint: one for self-managed and one for using the AWS managed service
Signed-off-by: Josh Hart <[email protected]>

---------

Co-authored-by: Josh Hart <[email protected]>
(cherry picked from commit ed6b080)
ylwu-amzn pushed a commit that referenced this pull request Oct 12, 2023
@jhart0 @ylwu-amzn
add bedrock blueprint doc (#1429)
9ac3c8b 
* add bedrock blueprint doc
Signed-off-by: Josh Hart <[email protected]>

* add 2 versions of connector blueprint: one for self-managed and one for using the AWS managed service
Signed-off-by: Josh Hart <[email protected]>

---------

Co-authored-by: Josh Hart <[email protected]>
(cherry picked from commit ed6b080)
Signed-off-by: Yaliang Wu <[email protected]>
dhrubo-os pushed a commit that referenced this pull request Oct 12, 2023
@opensearch-trigger-bot @jhart0
add bedrock blueprint doc (#1429) (#1501)
7c8aea6 
* add bedrock blueprint doc


* add 2 versions of connector blueprint: one for self-managed and one for using the AWS managed service


---------


(cherry picked from commit ed6b080)

Signed-off-by: Yaliang Wu <[email protected]>
Co-authored-by: Josh Hart <[email protected]>
Co-authored-by: Josh Hart <[email protected]>
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 21, 2023
@jhart0 @TrungBui59
add bedrock blueprint doc (opensearch-project#1429)
6746387 
* add bedrock blueprint doc
Signed-off-by: Josh Hart <[email protected]>

* add 2 versions of connector blueprint: one for self-managed and one for using the AWS managed service
Signed-off-by: Josh Hart <[email protected]>

---------

Co-authored-by: Josh Hart <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbhavna rbhavna rbhavna approved these changes

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@wujunshen wujunshen Awaiting requested review from wujunshen

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhart0 @ylwu-amzn @dhrubo-os @rbhavna