-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport to 2.x] fix more places where thread context not restored (#1421) #1423
Merged
+67
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1421) * fix more places where thread context not restored Signed-off-by: Yaliang Wu <[email protected]> * fix failed ut Signed-off-by: Yaliang Wu <[email protected]> * remove unused import Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 3, 2023 18:18 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 3, 2023 18:18 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 3, 2023 18:18 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 3, 2023 18:18 — with
GitHub Actions
Inactive
dhrubo-os
approved these changes
Oct 3, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1423 +/- ##
=========================================
Coverage 78.23% 78.23%
- Complexity 2305 2324 +19
=========================================
Files 195 195
Lines 9377 9397 +20
Branches 920 920
=========================================
+ Hits 7336 7352 +16
- Misses 1626 1631 +5
+ Partials 415 414 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b4sjoo
approved these changes
Oct 3, 2023
rbhavna
approved these changes
Oct 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
* fix more places where thread context not restored * fix failed ut * remove unused import --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit d8c1162)
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 5, 2023
) * fix more places where thread context not restored * fix failed ut * remove unused import --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit d8c1162) Co-authored-by: Yaliang Wu <[email protected]>
TrungBui59
pushed a commit
to TrungBui59/ml-commons
that referenced
this pull request
Nov 21, 2023
…#1421) (opensearch-project#1423) (opensearch-project#1436) * fix more places where thread context not restored * fix failed ut * remove unused import --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit d8c1162) Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: TrungBui59 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #1421 to 2.x