Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/backport 1274 to 2.x #1397

Merged

Conversation

zane-neo
Copy link
Collaborator

@zane-neo zane-neo commented Sep 27, 2023

Description

Backport #1274 to 2.x

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env September 27, 2023 03:08 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env September 27, 2023 03:08 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1397 (7b94c94) into 2.x (8de0431) will decrease coverage by 0.03%.
Report is 1 commits behind head on 2.x.
The diff coverage is 62.71%.

@@             Coverage Diff              @@
##                2.x    #1397      +/-   ##
============================================
- Coverage     78.30%   78.28%   -0.03%     
- Complexity     2271     2272       +1     
============================================
  Files           190      190              
  Lines          9284     9283       -1     
  Branches        910      909       -1     
============================================
- Hits           7270     7267       -3     
- Misses         1604     1608       +4     
+ Partials        410      408       -2     
Flag Coverage Δ
ml-commons 78.28% <62.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ain/java/org/opensearch/ml/engine/ModelHelper.java 89.92% <ø> (-0.08%) ⬇️
...va/org/opensearch/ml/engine/utils/ScriptUtils.java 90.00% <100.00%> (+13.52%) ⬆️
...ine/algorithms/remote/RemoteConnectorExecutor.java 88.46% <66.66%> (+1.79%) ⬆️
...ch/ml/engine/algorithms/remote/ConnectorUtils.java 65.88% <61.11%> (-5.74%) ⬇️

... and 1 file with indirect coverage changes

@ylwu-amzn ylwu-amzn merged commit 547ef21 into opensearch-project:2.x Sep 27, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants