Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] tags on model group #1370

Closed
wants to merge 3 commits into from
Closed

[FEATURE] tags on model group #1370

wants to merge 3 commits into from

Conversation

wujunshen
Copy link

see #1303

tags operation on model group

Signed-off-by: Frank Woo(吴峻申) <[email protected]>
check update tags whether is null or empty

Signed-off-by: Frank Woo(吴峻申) <[email protected]>
check update tags whether is null or empty

Signed-off-by: Frank Woo(吴峻申) <[email protected]>
@wujunshen wujunshen temporarily deployed to ml-commons-cicd-env September 25, 2023 08:50 — with GitHub Actions Inactive
@wujunshen wujunshen temporarily deployed to ml-commons-cicd-env September 25, 2023 08:50 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1370 (17822b6) into 2.x (2c8cc02) will decrease coverage by 0.15%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##                2.x    #1370      +/-   ##
============================================
- Coverage     78.35%   78.20%   -0.15%     
- Complexity     2275     2278       +3     
============================================
  Files           190      190              
  Lines          9286     9314      +28     
  Branches        910      918       +8     
============================================
+ Hits           7276     7284       +8     
- Misses         1599     1616      +17     
- Partials        411      414       +3     
Flag Coverage Δ
ml-commons 78.20% <42.85%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...n/model_group/TransportUpdateModelGroupAction.java 70.58% <30.43%> (-7.11%) ⬇️
...model_group/TransportRegisterModelGroupAction.java 100.00% <100.00%> (ø)
...a/org/opensearch/ml/model/MLModelGroupManager.java 83.89% <100.00%> (+0.27%) ⬆️

... and 1 file with indirect coverage changes

@wujunshen wujunshen temporarily deployed to ml-commons-cicd-env September 25, 2023 09:15 — with GitHub Actions Inactive
@wujunshen wujunshen temporarily deployed to ml-commons-cicd-env September 25, 2023 09:15 — with GitHub Actions Inactive
@wujunshen wujunshen temporarily deployed to ml-commons-cicd-env September 25, 2023 09:15 — with GitHub Actions Inactive
@wujunshen wujunshen temporarily deployed to ml-commons-cicd-env September 25, 2023 09:15 — with GitHub Actions Inactive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change the format of this file, the format change caused a lot of differences.

@wujunshen wujunshen closed this by deleting the head repository Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants