Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing messaging for ILlegalArgumentException on duplicate model gr… #1294

Merged
merged 2 commits into from
Sep 7, 2023
+2 −6
Merged

Changing messaging for ILlegalArgumentException on duplicate model gr… #1294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd71b7
Changing messaging for ILlegalArgumentException on duplicate model gr…
nateynateynate Sep 7, 2023
6346a57
Adjusting the test. `./gradlew test` passes.
nateynateynate Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions plugin/src/main/java/org/opensearch/ml/model/MLModelGroupManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,7 @@ public void createModelGroup(MLRegisterModelGroupInput input, ActionListener<Str
listener
.onFailure(
new IllegalArgumentException(
"The name you provided is already being used by another model with ID: "
+ id
+ ". Please provide a different name or add \"model_group_id\": \""
+ id
+ "\" to request body"
"The name you provided is already being used by a model group with ID: " + id + "."
)
);
}
Expand Down
2 changes: 1 addition & 1 deletion plugin/src/test/java/org/opensearch/ml/model/MLModelGroupManagerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public void test_ModelGroupNameNotUnique() throws IOException {//
ArgumentCaptor<Exception> argumentCaptor = ArgumentCaptor.forClass(Exception.class);
verify(actionListener).onFailure(argumentCaptor.capture());
assertEquals(
"The name you provided is already being used by another model with ID: model_group_ID. Please provide a different name or add \"model_group_id\": \"model_group_ID\" to request body",
"The name you provided is already being used by a model group with ID: model_group_ID.",
argumentCaptor.getValue().getMessage()
);

Expand Down