[Main] Fixing breaking changes from core in 3.0 #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
saratvemulapalli
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
wujunshen,
ylwu-amzn,
zane-neo and
Zhangxunmt
as code owners
dhrubo-os
approved these changes
Aug 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #1191 +/- ##
============================================
- Coverage 84.12% 84.06% -0.06%
+ Complexity 1755 1753 -2
============================================
Files 139 139
Lines 6716 6716
Branches 669 669
============================================
- Hits 5650 5646 -4
- Misses 769 772 +3
- Partials 297 298 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b4sjoo
approved these changes
Aug 7, 2023
|
@dhrubo-os @b4sjoo can we get this merged? Are we looking for anything else? |
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing breaking changes in main with OpenSearch 3.0
###Issues Resolved
Closes #1186
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.