Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fixing breaking changes from core #1189

Closed
wants to merge 2 commits into from
Closed

[2.x] Fixing breaking changes from core #1189

wants to merge 2 commits into from

Conversation

saratvemulapalli
Copy link
Member

Description

Fixing breaking changes from core:
opensearch-project/OpenSearch#9054
opensearch-project/OpenSearch#7508

Didn't realize there are open PRs #1187 #1182 , I was stumbling upon: #1179 bug and trying to repro, see 2.x not building.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <[email protected]>
@ylwu-amzn
Copy link
Collaborator

oh, just realize another PR fixing same issue #1187.

Signed-off-by: Sarat Vemulapalli <[email protected]>
@saratvemulapalli saratvemulapalli temporarily deployed to ml-commons-cicd-env August 7, 2023 20:43 — with GitHub Actions Inactive
@saratvemulapalli saratvemulapalli temporarily deployed to ml-commons-cicd-env August 7, 2023 20:43 — with GitHub Actions Inactive
@saratvemulapalli
Copy link
Member Author

oh, just realize another PR fixing same issue #1187.

Yup :). I can close this one, just opened up since I had the changes anyway.

@ylwu-amzn
Copy link
Collaborator

oh, just realize another PR fixing same issue #1187.

Yup :). I can close this one, just opened up since I had the changes anyway.

Thanks, I think we can use the #1187, you can help review and add comments there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants