Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix encoding US-ASCII error #1112

Closed
wants to merge 2 commits into from

Conversation

ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Jul 13, 2023

Description

[Describe what this change achieves]

Issues Resolved

#1111

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn
Copy link
Collaborator Author

31 tests completed, 5 failed, 9 skipped
Tests with failures:
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testCohereClassifyModel
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testCohereGenerateTextModel
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testPredictRemoteModel
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testOpenAIModerationsModel
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testOpenAIEditsModel

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jul 13, 2023

It is better after the #1114 but still shows this: @ylwu-amzn @ryanbogan

31 tests completed, 3 failed, 9 skipped
Tests with failures:
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testPredictRemoteModel
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testOpenAIEditsModel
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testOpenAIModerationsModel

@rbhavna rbhavna closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants