Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test keys to CI related workflows #1099

Conversation

peterzhuamazon
Copy link
Member

Description

Add test keys to CI related workflows.
(Remove dco.yml as it is not needed anymore due to dco app integration on all repositories)

Issues Resolved

Pre-requisite to #1073

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ylwu-amzn
ylwu-amzn previously approved these changes Jul 12, 2023
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon temporarily deployed to ml-commons-cicd-env July 12, 2023 18:27 — with GitHub Actions Inactive
@peterzhuamazon peterzhuamazon temporarily deployed to ml-commons-cicd-env July 12, 2023 18:27 — with GitHub Actions Inactive
@peterzhuamazon
Copy link
Member Author

The failure of the CI checks on credentials is expected as you need to merge the code into default branch before it can take effect.

Will merge then test with @ryanbogan @ylwu-amzn on this.

Thanks.

@peterzhuamazon
Copy link
Member Author

Offline talk with @ylwu-amzn and he is ok with the merge in this state, as it is expected to have the code merge 1st before the test can retrieve credentials.

Thanks.

@peterzhuamazon peterzhuamazon merged commit 62d9f20 into opensearch-project:2.x Jul 12, 2023
@peterzhuamazon peterzhuamazon deleted the add-test-keys-in-github-ci-2.x branch July 12, 2023 18:40
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2023
* Add test keys to CI related workflows

Signed-off-by: Peter Zhu <[email protected]>

* test more

Signed-off-by: Peter Zhu <[email protected]>

* more test

Signed-off-by: Peter Zhu <[email protected]>

* test

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 62d9f20)
peterzhuamazon added a commit that referenced this pull request Jul 12, 2023
* Add test keys to CI related workflows

Signed-off-by: Peter Zhu <[email protected]>

* test more

Signed-off-by: Peter Zhu <[email protected]>

* more test

Signed-off-by: Peter Zhu <[email protected]>

* test

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 62d9f20)

Co-authored-by: Peter Zhu <[email protected]>
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
* Add test keys to CI related workflows

Signed-off-by: Peter Zhu <[email protected]>

* test more

Signed-off-by: Peter Zhu <[email protected]>

* more test

Signed-off-by: Peter Zhu <[email protected]>

* test

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
* Add test keys to CI related workflows

Signed-off-by: Peter Zhu <[email protected]>

* test more

Signed-off-by: Peter Zhu <[email protected]>

* more test

Signed-off-by: Peter Zhu <[email protected]>

* test

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants