Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Require only one of 'llmQuestion' and 'llmMessages' for the RAG processor. #3067

Closed
austintlee opened this issue Oct 7, 2024 · 1 comment
Closed

[BUG] Require only one of 'llmQuestion' and 'llmMessages' for the RAG processor. #3067

austintlee opened this issue Oct 7, 2024 · 1 comment
Assignees
@austintlee
Labels
bug Something isn't working v2.18.0 Issues targeting release v2.18.0

Comments

@austintlee
Copy link
Collaborator

What is the bug?
We require that llmQuestion is always passed, but this is no longer the case when using Bedrocks' Converse API as input to the LLM can be passed in llmMessages.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

What is the expected behavior?
A clear and concise description of what you expected to happen.

What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.
@austintlee austintlee added bug Something isn't working untriaged v2.18.0 Issues targeting release v2.18.0 labels Oct 7, 2024
@austintlee austintlee self-assigned this Oct 7, 2024
@ylwu-amzn ylwu-amzn mentioned this issue Oct 7, 2024
Merged
5 tasks
austintlee added a commit to austintlee/ml-commons that referenced this issue Oct 8, 2024
@austintlee
Allow llmQuestion to be optional when llmMessages is used. (Issue ope…
138def6 
…nsearch-project#3067)

Signed-off-by: Austin Lee <[email protected]>
@austintlee austintlee mentioned this issue Oct 8, 2024
Merged
3 tasks
b4sjoo pushed a commit that referenced this issue Oct 9, 2024
@austintlee
Allow llmQuestion to be optional when llmMessages is used. (Issue #3… (…
48d275d 
…#3072)

* Allow llmQuestion to be optional when llmMessages is used.  (Issue #3067)

Signed-off-by: Austin Lee <[email protected]>

* Remove unused lines.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 9, 2024
@austintlee @github-actions
Allow llmQuestion to be optional when llmMessages is used. (Issue #3… (…
5d3b615 
…#3072)

* Allow llmQuestion to be optional when llmMessages is used.  (Issue #3067)

Signed-off-by: Austin Lee <[email protected]>

* Remove unused lines.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit 48d275d)
dhrubo-os pushed a commit that referenced this issue Oct 9, 2024
@opensearch-trigger-bot @austintlee
Allow llmQuestion to be optional when llmMessages is used. (Issue #3… (…
b8de799 
…#3072) (#3082)

* Allow llmQuestion to be optional when llmMessages is used.  (Issue #3067)

Signed-off-by: Austin Lee <[email protected]>

* Remove unused lines.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit 48d275d)

Co-authored-by: Austin Lee <[email protected]>
@pyek-bot
Copy link
Contributor

Can this issue be closed?

@dhrubo-os dhrubo-os moved this to Untriaged in ml-commons projects Oct 22, 2024
@github-project-automation github-project-automation bot moved this from Untriaged to Done in ml-commons projects Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austintlee austintlee

Labels
bug Something isn't working v2.18.0 Issues targeting release v2.18.0
Projects
ml-commons projects
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@austintlee @ylwu-amzn @dhrubo-os @pyek-bot