output only old fields in get config API (#2892)

Signed-off-by: Bhavana Ramaram <[email protected]>
opensearch-project · Sep 5, 2024 · 5f61df1 · 5f61df1
1 parent 8da7bd2
commit 5f61df1
Showing 1 changed file with 6 additions and 15 deletions.
diff --git a/common/src/main/java/org/opensearch/ml/common/MLConfig.java b/common/src/main/java/org/opensearch/ml/common/MLConfig.java
@@ -121,26 +121,17 @@ public void writeTo(StreamOutput out) throws IOException {
     @Override
     public XContentBuilder toXContent(XContentBuilder xContentBuilder, Params params) throws IOException {
         XContentBuilder builder = xContentBuilder.startObject();
-        if (type != null) {
-            builder.field(TYPE_FIELD, type);
+        if (configType != null || type != null) {
+            builder.field(TYPE_FIELD, configType == null ? type : configType);
         }
-        if (configType != null) {
-            builder.field(CONFIG_TYPE_FIELD, configType);
-        }
-        if (configuration != null) {
-            builder.field(CONFIGURATION_FIELD, configuration);
-        }
-        if (mlConfiguration != null) {
-            builder.field(ML_CONFIGURATION_FIELD, mlConfiguration);
+        if (configuration != null || mlConfiguration != null) {
+            builder.field(CONFIGURATION_FIELD, mlConfiguration == null ? configuration : mlConfiguration);
         }
         if (createTime != null) {
             builder.field(CREATE_TIME_FIELD, createTime.toEpochMilli());
         }
-        if (lastUpdateTime != null) {
-            builder.field(LAST_UPDATE_TIME_FIELD, lastUpdateTime.toEpochMilli());
-        }
-        if (lastUpdatedTime != null) {
-            builder.field(LAST_UPDATED_TIME_FIELD, lastUpdatedTime.toEpochMilli());
+        if (lastUpdateTime != null || lastUpdatedTime != null) {
+            builder.field(LAST_UPDATE_TIME_FIELD, lastUpdatedTime == null ? lastUpdateTime.toEpochMilli() : lastUpdatedTime.toEpochMilli());
         }
         return builder.endObject();
     }