Fix build errors after refactoring of Strings class in core #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
changed the title
martin-gaievski
force-pushed
the
fix-after-breaking-change-in-core
branch
from
fe56dcf to
9e40af4
Compare
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
junqiu-lei
as code owners
|
Core PR has 2.8 label, adding backport 2.x to this one |
martin-gaievski
force-pushed
the
fix-after-breaking-change-in-core
branch
from
9e40af4 to
3dde4cd
Compare
heemin32
previously approved these changes
May 19, 2023
heemin32
reviewed
May 19, 2023
| @@ -6,6 +6,7 @@ | |||
| package org.opensearch.knn.index.query; | |||
|
|
|||
| import lombok.extern.log4j.Log4j2; | |||
| import org.opensearch.core.Strings; | |||
There was a problem hiding this comment.
Is this correct package?
There was a problem hiding this comment.
fixed it, tried because of a failing integ tests, it appears that previous package was correct and instead recent core changes are not yet published for intg-test-zip artifact
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
fix-after-breaking-change-in-core
branch
from
3dde4cd to
4d972cd
Compare
heemin32
approved these changes
May 19, 2023
|
Integ tests are failing now, core change with refactoring of Strings class not yet published for iinteg-test-zip artifact |
junqiu-lei
approved these changes
May 19, 2023
naveentatikonda
approved these changes
May 19, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-904-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1b7baf6df7dd3a96ff2f307d03afdb1fc9aca7f0
# Push it to GitHub
git push --set-upstream origin backport/backport-904-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix imports after some refactoring in core under this PR opensearch-project/OpenSearch#7508
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.