Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Add windows support (#583) #642

Merged

Conversation

naveentatikonda
Copy link
Member

@naveentatikonda naveentatikonda commented Dec 2, 2022

  • Add Windows Support

Signed-off-by: Naveen [email protected]

Description

Add Windows Support to 1.x branch
Cherry-picked from 18403ff

Issues Resolved

#635

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Add Windows Support

Signed-off-by: Naveen <[email protected]>

* Add license for libwinpthread and copy all licenses to LICENSE.txt

Signed-off-by: Naveen <[email protected]>

* Download OpenBLAS

Signed-off-by: Naveen <[email protected]>

* Remove Git Patch and add branching logic for CMakeLists.txt

Signed-off-by: Naveen <[email protected]>

Signed-off-by: Naveen <[email protected]>
@naveentatikonda naveentatikonda added windows backport 1.3 Backports PRs to 1.3 branch v1.3.7 labels Dec 2, 2022
@naveentatikonda naveentatikonda requested a review from a team December 2, 2022 21:24
@naveentatikonda naveentatikonda changed the title Add windows support (#583) [1.x] Add windows support (#583) Dec 2, 2022
@martin-gaievski
Copy link
Member

Please cleanup PR description

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #642 (6b44bb8) into 1.x (98ce324) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x     #642      +/-   ##
============================================
+ Coverage     84.17%   84.24%   +0.07%     
  Complexity      906      906              
============================================
  Files           127      127              
  Lines          3879     3879              
  Branches        359      359              
============================================
+ Hits           3265     3268       +3     
+ Misses          455      452       -3     
  Partials        159      159              
Impacted Files Coverage Δ
...org/opensearch/knn/training/TrainingJobRunner.java 53.73% <0.00%> (+4.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@naveentatikonda naveentatikonda merged commit 4b9245e into opensearch-project:1.x Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 Backports PRs to 1.3 branch v1.3.7 windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants