-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build script to publish to maven local #596
Conversation
Updates build script to publish zip to local maven. This allows plugins like neural search to pick up the zip as a dependency. Fixes bug in build script where group was being set to org.opensearch as opposed to org.opensearch.plugin. Signed-off-by: John Mazanec <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #596 +/- ##
============================================
- Coverage 84.77% 84.51% -0.26%
+ Complexity 1059 1054 -5
============================================
Files 149 149
Lines 4301 4301
Branches 382 382
============================================
- Hits 3646 3635 -11
- Misses 480 489 +9
- Partials 175 177 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
build.gradle
Outdated
@@ -53,7 +53,7 @@ ext { | |||
|
|||
allprojects { | |||
|
|||
group = 'org.opensearch' | |||
group = 'org.opensearch.plugin' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not ideal because we set group=org.opensearch
so jars can be pushed to org/opensearch/<>
.
We then set groupId=org.opensearch.plugin
so zips can be pushed to org/opensearch/plugin/<>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For k-NN, we dont puish any jars at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmazanec15 you could keep group=org.opensearch
there and use groupId=org.opensearch.plugin
for ZIPs, it will fix the issue:
> Invalid publication 'nebula': supplied groupId (org.opensearch) does not match value from POM file (org.opensearch.plugin). Cannot edit groupId directly in the POM file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reta I believe this is what we do now:
- https://github.com/opensearch-project/k-NN/blob/main/build.gradle#L56
- https://github.com/opensearch-project/k-NN/blob/main/build.gradle#L91
I think I can leave as is, but change build script to use:
./gradlew publishPluginZipPublicationToMavenLocal
Signed-off-by: John Mazanec <[email protected]>
b0ae128
Signed-off-by: John Mazanec <[email protected]>
Updates build script to publish zip to local maven. This allows plugins like neural search to pick up the zip as a dependency. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 5323699)
Description
Updates build script to publish zip to local maven. This allows plugins like neural search to pick up the zip as a dependency.
Fixes bug in build script where group was being set to org.opensearch as opposed to org.opensearch.plugin.
Publish to maven passed:
Issues Resolved
opensearch-project/neural-search#31
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.