Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.3.1 #331

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Bump version to 1.3.1 #331

merged 3 commits into from
Mar 28, 2022

Conversation

gaiksaya
Copy link
Member

Signed-off-by: Sayali Gaikawad [email protected]

Description

Bump version to 1.3.1

Issues Resolved

Part of opensearch-project/opensearch-build#1805

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya requested a review from a team March 25, 2022 23:55
@gaiksaya
Copy link
Member Author

Hi @opensearch-project/k-nn team, can someone take a look at failing CIs and let me know if anything needs to be changed?
Thanks!

@naveentatikonda
Copy link
Member

naveentatikonda commented Mar 28, 2022

@gaiksaya Can you update this https://github.com/gaiksaya/k-NN-1/blob/1.3.1/.github/workflows/CI.yml#L38 to '1.3.1'

Hi @opensearch-project/k-nn team, can someone take a look at failing CIs and let me know if anything needs to be changed? Thanks!

@gaiksaya, I think the issue is with https://github.com/gaiksaya/k-NN-1/blob/1.3.1/.github/workflows/CI.yml#L38, which needs to be updated to 1.3.1. I'm testing it, the github action is running.

I guess it is copying both zip files opensearch-knn-1.3.0.0-SNAPSHOT.zip and opensearch-knn-1.3.1.0-SNAPSHOT.zip from distributions to BWC resources which is causing BWC Tests to fail.

Signed-off-by: Sayali Gaikawad <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #331 (0fdac5d) into 1.3 (20352a3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.3     #331   +/-   ##
=========================================
  Coverage     83.41%   83.41%           
  Complexity      889      889           
=========================================
  Files           127      127           
  Lines          3841     3841           
  Branches        361      361           
=========================================
  Hits           3204     3204           
  Misses          475      475           
  Partials        162      162           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20352a3...0fdac5d. Read the comment docs.

@jmazanec15
Copy link
Member

@gaiksaya Could we change CI as @peterzhuamazon did in #334 so that we wont have to update this for every patch?

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya
Copy link
Member Author

@gaiksaya Could we change CI as @peterzhuamazon did in #334 so that we wont have to update this for every patch?

Removed. Looks like good approach.
Thanks!

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@gaiksaya gaiksaya merged commit e633f74 into opensearch-project:1.3 Mar 28, 2022
@gaiksaya gaiksaya deleted the 1.3.1 branch March 28, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants