-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 1.3.1 #331
Conversation
Signed-off-by: Sayali Gaikawad <[email protected]>
Hi @opensearch-project/k-nn team, can someone take a look at failing CIs and let me know if anything needs to be changed? |
@gaiksaya Can you update this https://github.com/gaiksaya/k-NN-1/blob/1.3.1/.github/workflows/CI.yml#L38 to '1.3.1'
@gaiksaya, I think the issue is with https://github.com/gaiksaya/k-NN-1/blob/1.3.1/.github/workflows/CI.yml#L38, which needs to be updated to 1.3.1. I'm testing it, the github action is running. I guess it is copying both zip files opensearch-knn-1.3.0.0-SNAPSHOT.zip and opensearch-knn-1.3.1.0-SNAPSHOT.zip from distributions to BWC resources which is causing BWC Tests to fail. |
Signed-off-by: Sayali Gaikawad <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 1.3 #331 +/- ##
=========================================
Coverage 83.41% 83.41%
Complexity 889 889
=========================================
Files 127 127
Lines 3841 3841
Branches 361 361
=========================================
Hits 3204 3204
Misses 475 475
Partials 162 162 Continue to review full report at Codecov.
|
@gaiksaya Could we change CI as @peterzhuamazon did in #334 so that we wont have to update this for every patch? |
Signed-off-by: Sayali Gaikawad <[email protected]>
Removed. Looks like good approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Signed-off-by: Sayali Gaikawad [email protected]
Description
Bump version to 1.3.1
Issues Resolved
Part of opensearch-project/opensearch-build#1805
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.