Fix shard level rescoring disabled setting flag #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
added
Bug Fixes
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
naveentatikonda
force-pushed
the
fix_shard_level_rescoring_setting
branch
from
b6780d5 to
5d62f00
Compare
navneet1v
previously approved these changes
Dec 24, 2024
|
@shatejas , @jmazanec15 , @Vikasht34 please take a look at this please. |
Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
force-pushed
the
fix_shard_level_rescoring_setting
branch
from
5d62f00 to
b4fe9cb
Compare
shatejas
reviewed
Dec 25, 2024
Verified with debugger. It is working as expected. Can you pls review it again. Thanks! |
navneet1v
approved these changes
Dec 25, 2024
shatejas
approved these changes
Dec 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 25, 2024
(cherry picked from commit c728f02)
naveentatikonda
added a commit
that referenced
this pull request
Dec 26, 2024
(cherry picked from commit c728f02) Co-authored-by: Naveen Tatikonda <[email protected]>
buddharajusahil
pushed a commit
to buddharajusahil/k-NN
that referenced
this pull request
Dec 31, 2024
Gankris96
pushed a commit
to Gankris96/k-NN
that referenced
this pull request
Dec 31, 2024
Gankris96
pushed a commit
to Gankris96/k-NN
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix shard level rescoring disabled index setting flag(
index.knn.disk.vector.shard_level_rescoring_disabled) to enable shard level rescoring.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.