Java Docs Fix for 2.x in Linux Machine #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vikasht34
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
Signed-off-by: VIKASH TIWARI <[email protected]>
jmazanec15
reviewed
Oct 7, 2024
| @@ -43,30 +43,6 @@ public final class RescoreContext { | |||
| * Flag to track whether the oversample factor is user-provided or default. The Reason to introduce | |||
| * this is to set default when Shard Level rescoring is false, | |||
| * else we end up overriding user provided value in NativeEngineKnnVectorQuery | |||
| * | |||
| * | |||
| * This flag is crucial to differentiate between user-defined oversample factors and system-assigned | |||
There was a problem hiding this comment.
Why is this invalid? Can we just add
if necessary?
There was a problem hiding this comment.
Yeah ..I thought it's long ,..,and some of them causing Java Docs to Fail , so thought of keep it simple ..Let me add back!!
jmazanec15
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Java Docs Fix for 2.x in Linux Machine
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.