[Backport 2.x] Introducing a loading layer in FAISS native engine. #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Introducing a loading layer in FAISS native engine. Signed-off-by: Dooyong Kim <[email protected]> * Update change log. Signed-off-by: Dooyong Kim <[email protected]> * Added unit tests for Faiss stream support. Signed-off-by: Dooyong Kim <[email protected]> * Fix a bug to pass a KB size integer value as a byte size integer parameter. Signed-off-by: Dooyong Kim <[email protected]> * Fix a casting bugs when it tries to laod more than 4G sized index file. Signed-off-by: Dooyong Kim <[email protected]> * Added unit tests for new methods in JNIService. Signed-off-by: Dooyong Kim <[email protected]> * Fix formatting and removed nmslib_stream_support. Signed-off-by: Dooyong Kim <[email protected]> * Removing redundant exception message in JNIService.loadIndex. Signed-off-by: Dooyong Kim <[email protected]> * Fix a flaky testing - testIndexAllocation_closeBlocking Signed-off-by: Dooyong Kim <[email protected]> --------- Signed-off-by: Dooyong Kim <[email protected]> Signed-off-by: Doo Yong Kim <[email protected]> Co-authored-by: Dooyong Kim <[email protected]> (cherry picked from commit f3b2bd0)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
navneet1v
approved these changes
Oct 3, 2024
heemin32
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f3b2bd0 from #2139