KNN80DocValues should only be considered for BinaryDocValues fields #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
|
@VijayanB thanks for catching and fixing this bug. |
|
@VijayanB I won't recommend doing skip-change log for this and add the entry in the change log. |
navneet1v
added
Bug Fixes
navneet1v
reviewed
Sep 25, 2024
src/main/java/org/opensearch/knn/index/codec/KNN80Codec/KNN80DocValuesProducer.java
Outdated
Show resolved
Hide resolved
jmazanec15
reviewed
Sep 25, 2024
src/main/java/org/opensearch/knn/index/codec/KNN80Codec/KNN80DocValuesProducer.java
Outdated
Show resolved
Hide resolved
VijayanB
force-pushed
the
add-condition
branch
from
5b577a1 to
bfbe2a4
Compare
VijayanB
force-pushed
the
add-condition
branch
from
bfbe2a4 to
2c156b4
Compare
Consider adding files from fields that has BinaryDocValues and doesn't have filter values in producer. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
add-condition
branch
from
2c156b4 to
fe53f16
Compare
Ack |
This was referenced Sep 25, 2024
jmazanec15
approved these changes
Sep 25, 2024
navneet1v
reviewed
Sep 25, 2024
navneet1v
approved these changes
Sep 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
…2147) Consider adding files from fields that has BinaryDocValues and doesn't have filter values in producer. Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit 329fc57)
VijayanB
added a commit
that referenced
this pull request
Sep 26, 2024
…2147) (#2151) Consider adding files from fields that has BinaryDocValues and doesn't have filter values in producer. Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit 329fc57) Co-authored-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KNN80DocValuesProducer should consider adding files from fields that has BinaryDocValues and doesn't have vector values in producer. By default, k-NN field types post 2.17 don't create BinaryDocValues for knn field anymore. However, users can set doc_values = true, to create BinaryDocValues explicitly like any other field, though it is not used for approximate search. Hence, we want to avoid considering fields that is created using NativeEngines990KnnVectorsFormat. Checking doc Type not equal to BinayDocValues and field doesn't have vectors will make sure we don't accidentally add native engine files that are created from NativeEngines990KnnVectorsFormat.
Related Issues
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.