Fix native engine vector format test #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
|
Thanks @VijayanB for making the test tighter. Somehow when integration happened with NativeIndexWriter the update of this test was missed. Good catch. Approving the code. Assuming tests will pass. |
navneet1v
previously approved these changes
Sep 12, 2024
VijayanB
force-pushed
the
fix-format-test
branch
from
93626cc to
a76ef6b
Compare
Previosuly we were not creating hnsw file on segment flush for faiss engine. After successfully integrating hnsw file creation, we forgot to update unit test. Here, we will confirm that required files are being created based on field type. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
fix-format-test
branch
from
a76ef6b to
633bace
Compare
jmazanec15
approved these changes
Sep 13, 2024
naveentatikonda
approved these changes
Sep 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Previosuly we were not creating hnsw file on segment flush for faiss engine. After successfully integrating hnsw file creation, we forgot to update unit test. Here, we will confirm that required files are being created based on field type. Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit 8277bf0)
navneet1v
pushed a commit
that referenced
this pull request
Sep 14, 2024
Previosuly we were not creating hnsw file on segment flush for faiss engine. After successfully integrating hnsw file creation, we forgot to update unit test. Here, we will confirm that required files are being created based on field type. Signed-off-by: Vijayan Balasubramanian <[email protected]> (cherry picked from commit 8277bf0) Co-authored-by: Vijayan Balasubramanian <[email protected]>
VijayanB
added a commit
that referenced
this pull request
Sep 17, 2024
… creation (#2007) * Fix native engine vector format test (#2103) Previosuly we were not creating hnsw file on segment flush for faiss engine. After successfully integrating hnsw file creation, we forgot to update unit test. Here, we will confirm that required files are being created based on field type. Signed-off-by: Vijayan Balasubramanian <[email protected]> * Introduce a setting to control whether to build graph Added new updatable index setting "build_vector_data_structure_threshold", which will be considered when to build braph or not for native engines. This is noop for lucene. This depends on use lucene format as prerequisite. We don't need to add flag since it is only enable if lucene format is already enabled. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
added a commit
to VijayanB/k-NN-2
that referenced
this pull request
Sep 23, 2024
… creation (opensearch-project#2007) * Fix native engine vector format test (opensearch-project#2103) Previosuly we were not creating hnsw file on segment flush for faiss engine. After successfully integrating hnsw file creation, we forgot to update unit test. Here, we will confirm that required files are being created based on field type. Signed-off-by: Vijayan Balasubramanian <[email protected]> * Introduce a setting to control whether to build graph Added new updatable index setting "build_vector_data_structure_threshold", which will be considered when to build braph or not for native engines. This is noop for lucene. This depends on use lucene format as prerequisite. We don't need to add flag since it is only enable if lucene format is already enabled. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previosuly we were not creating hnsw file on segment flush for faiss engine. After successfully integrating hnsw file creation, we forgot to update unit test. In this PR, we will confirm that required files are being created based on field type.
Related Issues
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.