-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spaceType as a top level parameter while creating vector field. #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navneet Verma <[email protected]>
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
September 5, 2024 07:13
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
naveentatikonda
approved these changes
Sep 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…2044) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <[email protected]> * fix release notes Signed-off-by: John Mazanec <[email protected]> * Remove commented out code Signed-off-by: John Mazanec <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: John Mazanec <[email protected]> Co-authored-by: John Mazanec <[email protected]> (cherry picked from commit cb9ba71)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…2044) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <[email protected]> * fix release notes Signed-off-by: John Mazanec <[email protected]> * Remove commented out code Signed-off-by: John Mazanec <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: John Mazanec <[email protected]> Co-authored-by: John Mazanec <[email protected]> (cherry picked from commit cb9ba71)
naveentatikonda
pushed a commit
that referenced
this pull request
Sep 5, 2024
…2044) (#2050) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <[email protected]> * fix release notes Signed-off-by: John Mazanec <[email protected]> * Remove commented out code Signed-off-by: John Mazanec <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: John Mazanec <[email protected]> Co-authored-by: John Mazanec <[email protected]> (cherry picked from commit cb9ba71) Co-authored-by: Navneet Verma <[email protected]>
ryanbogan
pushed a commit
that referenced
this pull request
Sep 5, 2024
…2044) (#2049) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <[email protected]> * fix release notes Signed-off-by: John Mazanec <[email protected]> * Remove commented out code Signed-off-by: John Mazanec <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: John Mazanec <[email protected]> Co-authored-by: John Mazanec <[email protected]> (cherry picked from commit cb9ba71) Co-authored-by: Navneet Verma <[email protected]>
akashsha1
pushed a commit
to akashsha1/k-NN
that referenced
this pull request
Sep 16, 2024
…pensearch-project#2044) * Add spaceType as a top level parameter while creating vector field. Signed-off-by: Navneet Verma <[email protected]> * fix release notes Signed-off-by: John Mazanec <[email protected]> * Remove commented out code Signed-off-by: John Mazanec <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: John Mazanec <[email protected]> Co-authored-by: John Mazanec <[email protected]> Signed-off-by: Akash Shankaran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add spaceType as a top level parameter while creating vector field. With this change a user can change the spaceType for the vector field without defining the
method
parameter in the mapping. With this change Disk based vector search OOB experience is improved.Things to be added:
Tests will be added in followup PRs
How testing is done:
I have performed manual testing by running following create index request.
Success
Success and hits the legacy method and use the innerproduct space type
Related Issues
#1949
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.