Apply custom patch only once by comparing the patch-id of the last commit

[heemin32]

Description

As more custom patches are added, it fails to re-apply same patches if more than one patch touch the same file. This lead to consistent build failure whenever we build jni library more than once. The workaround with the failure is removing both git rebase-apply folder and external/faiss folder and build from scratch which is inconvenient and increase development time.

To resolve the issue, changed the cmake file to apply custom patch only once by comparing the patch-id of the last commit.

Also, removed submodule: true option in CI as it seems it is not needed anymore after we upgraded linux image for CI build.

Issues Resolved

N/A

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[heemin32]

Verifying if removing submodule: true works in CI. If this change works, it is thanks to the #1636.

[jmazanec15]

@heemin32 In some cases, we need to pull the submodule from top level (see build script). So I dont think this approach would work with that

[heemin32]

@heemin32 In some cases, we need to pull the submodule from top level (see build script). So I dont think this approach would work with that

I can edit the build script as same as window.

git submodule update --init -- jni/external/nmslib
git -C jni/external/nmslib apply --3way --ignore-space-change --ignore-whitespace ../../patches/nmslib/0001-Initialize-maxlevel-during-add-from-enterpoint-level.patch
git -C jni/external/nmslib apply --3way --ignore-space-change --ignore-whitespace ../../patches/nmslib/0002-Adds-ability-to-pass-ef-parameter-in-the-query-for-h.patch

git submodule update --init -- jni/external/faiss
git -C jni/external/faiss apply --3way --ignore-space-change --ignore-whitespace ../../patches/faiss/0001-Custom-patch-to-support-multi-vector.patch
git -C jni/external/faiss apply --3way --ignore-space-change --ignore-whitespace ../../patches/faiss/0002-Enable-precomp-table-to-be-shared-ivfpq.patch
git -C jni/external/faiss apply --3way --ignore-space-change --ignore-whitespace ../../patches/faiss/0003-Custom-patch-to-support-range-search-params.patch
git -C jni/external/faiss apply --3way --ignore-space-change --ignore-whitespace ../../patches/faiss/0004-Custom-patch-to-support-binary-vector.patch

[heemin32]

@jmazanec15 raised a concern on having a list of patch file in multiple places and suggested to use git patch-id. Thanks.

[heemin32]

bwc test is failing for all PR now with Exception in thread "main" java.io.FileNotFoundException: /home/runner/work/k-NN/k-NN/qa/restart-upgrade/build/private/artifact_tmp/opensearch-knn-2.16.0.zip (No such file or directory)

[jmazanec15]

Thanks thats awesome!