Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing BWC tests as 2.15.0 is already launched #1811

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

navneet1v
Copy link
Collaborator

@navneet1v navneet1v commented Jul 10, 2024

Description

Fixing BWC tests as 2.15.0 is already launched

Issues Resolved

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v
Copy link
Collaborator Author

The failure test is:

 - org.opensearch.knn.index.query.KNNQueryBuilderInvalidParamsTests.testInvalidBuilder {description:k value greater than max; expectedMessage:[knn] requires k to be in the range (0, 10000]; querybuilder:org.opensearch.knn.index.query.KNNQueryBuilder$Builder@29c25bbc}

which is fixed in this PR: #1812

@navneet1v navneet1v merged commit a8d83bf into opensearch-project:main Jul 10, 2024
57 checks passed
ryanbogan pushed a commit to ryanbogan/k-NN that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants