Bump faiss commit to 33c0ba5 #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
heemin32
previously approved these changes
Jul 5, 2024
|
Can we add change log under maintenance? |
naveentatikonda
added
Maintenance
heemin32
previously approved these changes
Jul 5, 2024
|
@naveentatikonda cc: @vamshin , @jmazanec15 |
Sure once this fix(#1795 ) has been merged I will rebase my PR and merge only after all the CI checks are successful. |
Signed-off-by: Naveen Tatikonda <[email protected]>
Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
force-pushed
the
bump_faiss_commit_sq8
branch
from
9e68ea3 to
5c063a1
Compare
|
Linux CI failing with CMake version error Raised a PR to build repo to bump up CMake version to 3.26.4 |
Signed-off-by: Naveen Tatikonda <[email protected]>
|
Image built and pushed to docker hub. You can try again with the test now. Thanks. |
heemin32
approved these changes
Jul 10, 2024
jmazanec15
approved these changes
Jul 10, 2024
naveentatikonda
merged commit 8fb779d
into
opensearch-project:main
50 of 52 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Bump faiss commit to 33c0ba5 and update patches Signed-off-by: Naveen Tatikonda <[email protected]> * Add Changelog Signed-off-by: Naveen Tatikonda <[email protected]> * Set cmake minimum requirement to 3.24.0 Signed-off-by: Naveen Tatikonda <[email protected]> --------- Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit 8fb779d)
heemin32
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Bump faiss commit to 33c0ba5 and update patches Signed-off-by: Naveen Tatikonda <[email protected]> * Add Changelog Signed-off-by: Naveen Tatikonda <[email protected]> * Set cmake minimum requirement to 3.24.0 Signed-off-by: Naveen Tatikonda <[email protected]> --------- Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit 8fb779d) Co-authored-by: Naveen Tatikonda <[email protected]>
ryanbogan
pushed a commit
to ryanbogan/k-NN
that referenced
this pull request
Jul 16, 2024
* Bump faiss commit to 33c0ba5 and update patches Signed-off-by: Naveen Tatikonda <[email protected]> * Add Changelog Signed-off-by: Naveen Tatikonda <[email protected]> * Set cmake minimum requirement to 3.24.0 Signed-off-by: Naveen Tatikonda <[email protected]> --------- Signed-off-by: Naveen Tatikonda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#1659
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.