Adds Nprobe as a method parameter in knn query #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shatejas
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
junqiu-lei
approved these changes
Jun 14, 2024
shatejas
changed the title
shatejas
force-pushed
the
feature/ef-search
branch
from
da05093 to
097f8d9
Compare
ryanbogan
reviewed
Jun 17, 2024
|
@shatejas looks like there are some merge conflicts, but otherwise LGTM! |
Signed-off-by: Tejas Shah <[email protected]>
shatejas
force-pushed
the
feature/ef-search
branch
from
097f8d9 to
6da5ed0
Compare
Signed-off-by: Tejas Shah <[email protected]>
shatejas
force-pushed
the
feature/ef-search
branch
from
6da5ed0 to
cfc13a0
Compare
ryanbogan
approved these changes
Jun 20, 2024
junqiu-lei
added
Features
junqiu-lei
merged commit 7ee1ab4
into
opensearch-project:feature/ef-search
46 of 62 checks passed
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 3, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <[email protected]>
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 3, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <[email protected]>
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 3, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <[email protected]>
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 15, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <[email protected]>
5 tasks
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 16, 2024
Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <[email protected]>
navneet1v
pushed a commit
that referenced
this pull request
Jul 16, 2024
Adds integration test for invalid method parameters (#1782) Signed-off-by: Tejas Shah <[email protected]>
shatejas
added a commit
to shatejas/k-NN
that referenced
this pull request
Jul 16, 2024
…) (opensearch-project#1792) Adds integration test for invalid method parameters (opensearch-project#1782) Signed-off-by: Tejas Shah <[email protected]> (cherry picked from commit b422466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to have nprobes on query end
Issues Resolved
None
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.