Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support script score when doc value is disabled and fix misusing DISI #1711

Merged
merged 1 commit into from
May 21, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4d59d4c from #1696

…#1696)

* Revert "Revert 'Support script score when doc value is disabled' (#1662)"

This reverts commit bd2f403.

Signed-off-by: panguixin <[email protected]>

* fix misusing doc value

Signed-off-by: panguixin <[email protected]>

* add changelog

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
(cherry picked from commit 4d59d4c)
@jmazanec15
Copy link
Member

Flaky recall issue:


org.opensearch.knn.recall.RecallTestsIT > testRecall_whenFaissHnswFP32_thenRecallAbove75percent FAILED
    java.lang.AssertionError: expected:<1.0> but was:<0.7483000183105468>
REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.knn.recall.RecallTestsIT.testRecall_whenFaissHnswFP32_thenRecallAbove75percent" -Dtests.seed=43FD3FA61FB30388 -Dtests.security.manager=false -Dtests.locale=no -Dtests.timezone=America/Ojinaga -Druntime.java=17
        at __randomizedtesting.SeedInfo.seed([43FD3FA61FB30388:A38956C81BBCF7D]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:555)
        at org.junit.Assert.assertEquals(Assert.java:685)
        at org.opensearch.knn.recall.RecallTestsIT.assertRecall(RecallTestsIT.java:476)
        at org.opensearch.knn.recall.RecallTestsIT.testRecall_whenFaissHnswFP32_thenRecallAbove75percent(RecallTestsIT.java:255)

Will create issue. Not related to this PR

@jmazanec15 jmazanec15 merged commit c2c1660 into 2.x May 21, 2024
92 of 95 checks passed
@github-actions github-actions bot deleted the backport/backport-1696-to-2.x branch May 21, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants