Ensure blas is statically linked #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
added
Infrastructure
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
|
These failures for linux are related to using gcc 12 (opensearch-project/opensearch-build#4379 (comment)). We are moving to gcc 11, so we need to ignore these failures for now. |
|
@jmazanec15 Have you tested it on Windows? |
ryanbogan
approved these changes
Apr 30, 2024
|
@naveentatikonda the CI passed for windows |
naveentatikonda
approved these changes
Apr 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 1961e58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where we set BLA_STATIC after we find the package, leading OpenBlas to be dynamically linked instead of statically linked. In 2.13 it was the other way around: https://github.com/opensearch-project/k-NN/blob/2.13/jni/CMakeLists.txt#L126-L157
Bug was introduced in #1636
Issues Resolved
Related opensearch-project/opensearch-build#4379 (comment). This may resolve the issue with binutils because we are statically linking.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.